SDL file path fixes #749
Merged
SDL file path fixes #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 234a0e2. This was fixed in emscripten-ports/SDL2 version_23, which was included in Emscripten 2.0.17. We're already have 2.0.18 in the actions for the SDK/boilerplate for the libjpeg download error, so this should be okay.
Some of these might not make sense, but update all of them to be consistent. Also they would all work on non-SDL as there isn't a "base path"
|
Thank you! Looks like we're long overdue a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an Emscripten workaround (I fixed it in SDL and we're already using a version with the fix) and makes save paths work everywhere instead of just
open_file.Which would be really handy if someone wanted to add a
remove_savewrapper 😄