Add remove_save method to delete existing save data #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackhawk-TA
changed the title
Blackhawk-TA
changed the title
Gadgetoid
reviewed
Jan 27, 2022
32blit-sdl/File.cpp
Outdated
| @@ -182,7 +182,13 @@ bool rename_file(const std::string &old_name, const std::string &new_name) { | |||
| } | |||
|
|
|||
| bool remove_file(const std::string &path) { | |||
| return remove((basePath + path).c_str()) == 0; | |||
| // check if the path is under the save path and do not add basePath if this is the case | |||
There was a problem hiding this comment.
This should be unnecessary, since the generic "remove_file" probably still wants to be able to delete things from / (firmware/launcher updates for example)
|
Should be no need to change We have no pretense of filesystem safety here 😆 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to delete existing save files, therefore I added this functionality to the api.
Waiting for #749 to be merged.