Added 'pm' and 'mm' for very small and large scans #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As #796 seeks to address an issue with non-square images that were 1 pixel wide it makes sense to have such scenarios tested. + The `pytest.param()` function is used to add meaningful identifiers to each of the tests. + Adds a `1x512` pixel scan to the parameters (denoted `pn units; rectangular (thin)`). + Conversely adds a `512x1` pixel scan to the parameters (denoted `pm units; rectangular (tall)`) I'm unsure... + whether the `tall` test makes sense but then I'm also don't know why there would be an image that is only 1 pixel wide. + why the `expected_px2nm` is always based on the x-axis size and whether this would be an issue?
|
The error and associated fix in #796 were only discovered by the 1x512px image, not the cause of it. The microscope thought it foolish to record the 0.87nm long direction in 'nm' but instead 'pm'., not because of the non-squareness of the image, and thus the 'pm' test has already been added. Apologies if this wasn't clear. As the function currently requires each pixel to be square (the indexing of 0 in |
MaxGamill-Sheffield
merged commit de3ac4b
into
maxgamill-sheffield/pm-in-spm-dict
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #796 seeks to address an issue with non-square images that were 1 pixel wide it makes sense to have such scenarios
tested.
pytest.param()function is used to add meaningful identifiers to each of the tests.1x512pixel scan to the parameters (denotedpn units; rectangular (thin)).512x1pixel scan to the parameters (denotedpm units; rectangular (tall))I'm unsure...
talltest makes sense but then I'm also don't know why there would be an image that is only 1 pixel wide.expected_px2nmis always based on the x-axis size and whether this would be an issue?