Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'pm' and 'mm' for very small and large scans #801

Commits on Feb 12, 2024

  1. Adds non-square scans to tests

    As #796 seeks to address an issue with non-square images that were 1 pixel wide it makes sense to have such scenarios
    tested.
    
    + The `pytest.param()` function is used to add meaningful identifiers to each of the tests.
    + Adds a `1x512` pixel scan to the parameters (denoted `pn units; rectangular (thin)`).
    + Conversely adds a `512x1` pixel scan to the parameters (denoted `pm units; rectangular (tall)`)
    
    I'm unsure...
    
    + whether the `tall` test makes sense but then I'm also don't know why there would be an image that is only 1 pixel wide.
    + why the `expected_px2nm` is always based on the x-axis size and whether this would be an issue?
    ns-rse committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    0e2a133 View commit details
    Browse the repository at this point in the history