refactor(grainstats): GrainStats.get_max_min_feret() > measure.feret #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #798 Replaces the functionality for calculating minimum and maximum feret distances within the `GrainStats` class with the new `topostats.measure.feret.min_max_feret()`. + Reorder dictionary returned by `min_max_feret()`. + Dictionary is included in the `stats` dictionary built by `GrainStats` and saved as CSV. + Updates `tests/test_grainstats_minicircle.py::test_grainstats_regression` to include the co-ordinates. + Updates `tests/test_grainstats.py::test_process_scan*` to include co-ordinates. + Removes `GrainStats.get_max_min_feret()` and associated methods that are called as well as their tests. + Co-ordinates for min/max feret are included by default in HDF5 output now that they are part of the returned dataframe. Will have to rethink/change how results are returned by `GraintStats` class if height profiles are to be extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.
Closes #798 Replaces the functionality for calculating minimum and maximum feret distances within the `GrainStats` class with the new `topostats.measure.feret.min_max_feret()`. + Reorder dictionary returned by `min_max_feret()`. + Dictionary is included in the `stats` dictionary built by `GrainStats` and saved as CSV. + Updates `tests/test_grainstats_minicircle.py::test_grainstats_regression` to include the co-ordinates. + Updates `tests/test_grainstats.py::test_process_scan*` to include co-ordinates. + Removes `GrainStats.get_max_min_feret()` and associated methods that are called as well as their tests. + Co-ordinates for min/max feret are included by default in HDF5 output now that they are part of the returned dataframe. These are rounded to 13 decimal places to address precision errors encountered on Windows machines running the test suite. Will have to rethink/change how results are returned by `GraintStats` class if height profiles are to be extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.
Closes #798 Replaces the functionality for calculating minimum and maximum feret distances within the `GrainStats` class with the new `topostats.measure.feret.min_max_feret()`. + Reorder dictionary returned by `min_max_feret()`. + Dictionary is included in the `stats` dictionary built by `GrainStats` and saved as CSV. + Updates `tests/test_grainstats_minicircle.py::test_grainstats_regression` to include the co-ordinates. + Updates `tests/test_grainstats.py::test_process_scan*` to include co-ordinates. + Removes `GrainStats.get_max_min_feret()` and associated methods that are called as well as their tests. + Co-ordinates for min/max feret are included by default in HDF5 output now that they are part of the returned dataframe. These are rounded to 13 decimal places to address precision errors encountered on Windows machines running the test suite. Will have to rethink/change how results are returned by `GraintStats` class if height profiles are to be extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.
MaxGamill-Sheffield
approved these changes
Apr 17, 2024
|
Consider excluding co-ordinates from GrainStats output. |
ns-rse
added a commit
that referenced
this pull request
Apr 17, 2024
Further to #823 this reverts the GrainStats output to its previous form and removes the feret co-ordinates from the output as discussed in this mornings meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #798
Replaces the functionality for calculating minimum and maximum feret distances within the
GrainStatsclass with the newtopostats.measure.feret.min_max_feret().min_max_feret().statsdictionary built byGrainStatsand saved as CSV.tests/test_grainstats_minicircle.py::test_grainstats_regressionto include the co-ordinates.tests/test_grainstats.py::test_process_scan*to include co-ordinates.GrainStats.get_max_min_feret()and associated methods that are called as well as their tests.Will have to rethink/change how results are returned by
GraintStatsclass if height profiles are to be extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.