Commits on Apr 15, 2024

1. refactor(grainstats): GrainStats.get_max_min_feret() > measure.feret …

   Closes #798
   
   Replaces the functionality for calculating minimum and maximum feret distances within the `GrainStats`  class with the
   new `topostats.measure.feret.min_max_feret()`.
   
   + Reorder dictionary returned by `min_max_feret()`.
   + Dictionary is included in the `stats` dictionary built by `GrainStats` and saved as CSV.
   + Updates `tests/test_grainstats_minicircle.py::test_grainstats_regression` to include the co-ordinates.
   + Updates `tests/test_grainstats.py::test_process_scan*` to include co-ordinates.
   + Removes `GrainStats.get_max_min_feret()` and associated methods that are called as well as their tests.
   + Co-ordinates for min/max feret are included by default in HDF5 output now that they are part of the returned
     dataframe.
   
   Will have to rethink/change how results are returned by `GraintStats` class if height profiles are to be
   extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.

   

   ns-rse committed Apr 15, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 50c0c36
   • Browse repository at this point

   Copy the full SHA

   50c0c36 View commit details

   Browse the repository at this point in the history

2. Merge branch 'main' into ns-rse/748-grain-profiles-grainstats

   

   ns-rse authored Apr 15, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 74916b1
   • Browse repository at this point

   Copy the full SHA

   74916b1 View commit details

   Browse the repository at this point in the history

3. refactor(grainstats): GrainStats.get_max_min_feret() > measure.feret …

   Closes #798
   
   Replaces the functionality for calculating minimum and maximum feret distances within the `GrainStats`  class with the
   new `topostats.measure.feret.min_max_feret()`.
   
   + Reorder dictionary returned by `min_max_feret()`.
   + Dictionary is included in the `stats` dictionary built by `GrainStats` and saved as CSV.
   + Updates `tests/test_grainstats_minicircle.py::test_grainstats_regression` to include the co-ordinates.
   + Updates `tests/test_grainstats.py::test_process_scan*` to include co-ordinates.
   + Removes `GrainStats.get_max_min_feret()` and associated methods that are called as well as their tests.
   + Co-ordinates for min/max feret are included by default in HDF5 output now that they are part of the returned
     dataframe. These are rounded to 13 decimal places to address precision errors encountered on Windows machines running
     the test suite.
   
   Will have to rethink/change how results are returned by `GraintStats` class if height profiles are to be
   extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.

   

   ns-rse committed Apr 15, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 3130a7a
   • Browse repository at this point

   Copy the full SHA

   3130a7a View commit details

   Browse the repository at this point in the history

4. refactor(grainstats): GrainStats.get_max_min_feret() > measure.feret …

   Closes #798
   
   Replaces the functionality for calculating minimum and maximum feret distances within the `GrainStats`  class with the
   new `topostats.measure.feret.min_max_feret()`.
   
   + Reorder dictionary returned by `min_max_feret()`.
   + Dictionary is included in the `stats` dictionary built by `GrainStats` and saved as CSV.
   + Updates `tests/test_grainstats_minicircle.py::test_grainstats_regression` to include the co-ordinates.
   + Updates `tests/test_grainstats.py::test_process_scan*` to include co-ordinates.
   + Removes `GrainStats.get_max_min_feret()` and associated methods that are called as well as their tests.
   + Co-ordinates for min/max feret are included by default in HDF5 output now that they are part of the returned
     dataframe. These are rounded to 13 decimal places to address precision errors encountered on Windows machines running
     the test suite.
   
   Will have to rethink/change how results are returned by `GraintStats` class if height profiles are to be
   extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.

   

   ns-rse committed Apr 15, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for c7111af
   • Browse repository at this point

   Copy the full SHA

   c7111af View commit details

   Browse the repository at this point in the history