Skip to content

Commit

Permalink
workflows: invoke bash with -e (#1473)
Browse files Browse the repository at this point in the history
This will cause failures of simple commands to exit immediately. This
would have detected the use of an incorrect hash in libsharpyuv.cmd
which was fixed in:
29dfb12 libsharpyuv.cmd: fix commit hash (#1472)
  • Loading branch information
jzern authored Jul 14, 2023
1 parent 29dfb12 commit 41ed914
Show file tree
Hide file tree
Showing 8 changed files with 33 additions and 27 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci-disable-gtest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,27 +53,27 @@ jobs:
- name: Build aom
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash aom.cmd
run: bash -e aom.cmd
- name: Build dav1d
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash dav1d.cmd
run: bash -e dav1d.cmd
- name: Build rav1e
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash rav1e.cmd
run: bash -e rav1e.cmd
- name: Build SVT-AV1
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash svt.cmd
run: bash -e svt.cmd
- name: Build libyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libyuv.cmd
run: bash -e libyuv.cmd
- name: Build libsharpyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libsharpyuv.cmd
run: bash -e libsharpyuv.cmd

- name: Prepare libavif (cmake)
run: >
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-unix-shared-installed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- name: Build GoogleTest
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash googletest.cmd
run: bash -e googletest.cmd

- name: Prepare libavif (cmake)
run: >
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci-unix-shared-local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,23 +58,23 @@ jobs:
- name: Build aom
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash aom.cmd
run: bash -e aom.cmd
- name: Build dav1d
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash dav1d.cmd
run: bash -e dav1d.cmd
- name: Build libyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libyuv.cmd
run: bash -e libyuv.cmd
- name: Build libsharpyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libsharpyuv.cmd
run: bash -e libsharpyuv.cmd
- name: Build GoogleTest
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash googletest.cmd
run: bash -e googletest.cmd

- name: Prepare libavif (cmake)
run: >
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci-unix-static-av2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,32 +47,32 @@ jobs:
- name: Build avm
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash avm.cmd
run: bash -e avm.cmd
- name: Build dav1d
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash dav1d.cmd
run: bash -e dav1d.cmd
- name: Build rav1e
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash rav1e.cmd
run: bash -e rav1e.cmd
- name: Build SVT-AV1
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash svt.cmd
run: bash -e svt.cmd
- name: Build libyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libyuv.cmd
run: bash -e libyuv.cmd
- name: Build libsharpyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libsharpyuv.cmd
run: bash -e libsharpyuv.cmd
- name: Build GoogleTest
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
# Note: "apt install googletest" is sometimes insufficient for find_package(GTest) so build in ext/ instead.
run: bash googletest.cmd
run: bash -e googletest.cmd

- name: Prepare libavif (cmake)
run: >
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/ci-unix-static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,36 +50,36 @@ jobs:
- name: Build aom
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash aom.cmd
run: bash -e aom.cmd
- name: Build dav1d
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash dav1d.cmd
run: bash -e dav1d.cmd
- name: Build rav1e
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash rav1e.cmd
run: bash -e rav1e.cmd
- name: Build SVT-AV1
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash svt.cmd
run: bash -e svt.cmd
- name: Build libgav1
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libgav1.cmd
run: bash -e libgav1.cmd
- name: Build libyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libyuv.cmd
run: bash -e libyuv.cmd
- name: Build libsharpyuv
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: bash libsharpyuv.cmd
run: bash -e libsharpyuv.cmd
- name: Build GoogleTest
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
# Note: "apt install googletest" is sometimes insufficient for find_package(GTest) so build in ext/ instead.
run: bash googletest.cmd
run: bash -e googletest.cmd

- name: Prepare libavif (cmake)
run: >
Expand Down
2 changes: 2 additions & 0 deletions ext/dav1d_android.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
# The git tag below is known to work, and will occasionally be updated. Feel
# free to use a more recent commit.

set -e

if [ $# -ne 1 ]; then
echo "Usage: ${0} <path_to_android_ndk>"
exit 1
Expand Down
2 changes: 2 additions & 0 deletions ext/libgav1_android.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
# The git tag below is known to work, and will occasionally be updated. Feel
# free to use a more recent commit.

set -e

if [ $# -ne 1 ]; then
echo "Usage: ${0} <path_to_android_ndk>"
exit 1
Expand Down
2 changes: 2 additions & 0 deletions ext/svt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# then enable CMake's AVIF_CODEC_SVT and AVIF_LOCAL_SVT options.
# cmake and ninja must be in your PATH.

set -e

git clone -b v1.6.0 --depth 1 https://gitlab.com/AOMediaCodec/SVT-AV1.git

cd SVT-AV1
Expand Down

0 comments on commit 41ed914

Please sign in to comment.