Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: invoke bash with -e #1473

Merged
merged 2 commits into from
Jul 14, 2023
Merged

workflows: invoke bash with -e #1473

merged 2 commits into from
Jul 14, 2023

Conversation

jzern
Copy link
Collaborator

@jzern jzern commented Jul 14, 2023

This will cause failures of simple commands to exit immediately. This
would have detected the use of an incorrect hash in libsharpyuv.cmd
which was fixed in:
29dfb12 libsharpyuv.cmd: fix commit hash (#1472)

@jzern
workflows: invoke bash with -e
d480682 
This will cause failures of simple commands to exit immediately. This
would have detected the use of an incorrect hash in libsharpyuv.cmd
which was fixed in:
29dfb12 libsharpyuv.cmd: fix commit hash (AOMediaCodec#1472)
@jzern jzern requested a review from wantehchang July 14, 2023 18:01
@jzern
Copy link
Collaborator Author

jzern commented Jul 14, 2023

Looks like at least one of the builds is affected. You can hold off on review.

@jzern
Copy link
Collaborator Author

jzern commented Jul 14, 2023

Looks like at least one of the builds is affected. You can hold off on review.

Might be a flake on CI / build-disable-gtest.

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b6616905e54389fffa575de3f0eb5a102e64f1b9:refs/remotes/pull/1473/merge
  Error: fatal: unable to access 'https://github.com/AOMediaCodec/libavif/': The requested URL returned error: 429
  The process '/usr/bin/git' failed with exit code 128
  Waiting 13 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b6616905e54389fffa575de3f0eb5a102e64f1b9:refs/remotes/pull/1[47](https://github.com/AOMediaCodec/libavif/actions/runs/5556925536/jobs/10150069070?pr=1473#step:2:52)3/merge
  Error: fatal: unable to access 'https://github.com/AOMediaCodec/libavif/': The requested URL returned error: 429
  The process '/usr/bin/git' failed with exit code 128
  Waiting 12 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b6616905e54389fffa575de3f0eb5a102e64f1b9:refs/remotes/pull/1473/merge
  Error: fatal: unable to access 'https://github.com/AOMediaCodec/libavif/': The requested URL returned error: 429
  Error: The process '/usr/bin/git' failed with exit code 128

wantehchang
wantehchang approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ext/dav1d_android.sh Show resolved Hide resolved
wantehchang
wantehchang approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jzern jzern merged commit 41ed914 into AOMediaCodec:main Jul 14, 2023
14 checks passed
@jzern jzern deleted the workflows-bash-e branch July 14, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzern @wantehchang