Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental reduced HEIF header #1432

Merged
merged 23 commits into from
Sep 1, 2023
Merged

Experimental reduced HEIF header #1432

merged 23 commits into from
Sep 1, 2023

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Jun 13, 2023

Remove a few hundred bytes of container boilerplate for simple images. This prototype uses a small box that expands in meaning to a full meta box with all defined items and properties.

Warning: This feature is experimental and forbidden by the current AVIF specification.

@y-guyon y-guyon force-pushed the reduced_header branch 2 times, most recently from ac3be3e to bc92180 Compare June 13, 2023 12:22
@y-guyon y-guyon mentioned this pull request Jun 13, 2023
Closed
@y-guyon
Copy link
Collaborator Author

y-guyon commented Jun 13, 2023 •
edited
Loading

I tried this patch on 889 random PNG images from the web.
avifenc -s 6 -q 75 gave files 7.7% smaller on average when the --minimize flag was used.

-s 6 -q 75 stats Regular AVIF file size Minimized AVIF file size Difference in bytes Ratio
Minimum 319 82 233 19.28%
Maximum 4,298,570 4,298,333 464 99.99%
Average 32, 279 32,013 266 92.30% (95.26% for s9)

On paris_icc_exif_xmp.png:

avifenc -s 6 -q 75 --ignore-icc --ignore-exif --ignore-xmp

generates headers of 282 bytes and 42 bytes without and with --minimize, respectively. This is without the 15,333 bytes of AV1 payload.

@y-guyon y-guyon force-pushed the reduced_header branch 6 times, most recently from f47f892 to cb0e1b8 Compare August 3, 2023 16:22
This was referenced Aug 3, 2023
Merged
Merged
Merged
@y-guyon y-guyon force-pushed the reduced_header branch 3 times, most recently from dcfbdb5 to 23066f8 Compare August 11, 2023 15:24
@y-guyon y-guyon marked this pull request as ready for review August 11, 2023 15:42
@y-guyon
Copy link
Collaborator Author

y-guyon commented Aug 11, 2023

avifROStreamReadBits() and avifRWStreamWriteBits() could be submitted separately and used in some parts of the existing parsing/writing code, such as avifParseCodecConfiguration() which reads individual bits.

maryla-uc
maryla-uc approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@maryla-uc maryla-uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments!

include/avif/internal.h Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/stream.c Outdated Show resolved Hide resolved
src/write.c Outdated Show resolved Hide resolved
src/write.c Show resolved Hide resolved
include/avif/internal.h Outdated Show resolved Hide resolved
@y-guyon y-guyon mentioned this pull request Aug 18, 2023
Merged
@y-guyon
Copy link
Collaborator Author

y-guyon commented Aug 18, 2023

Rebased to include #1506.

@y-guyon
Copy link
Collaborator Author

y-guyon commented Aug 19, 2023

Rebased because avifRWStreamWriteBox() and writeCodecConfig() signatures changed in #1498.

maryla-uc
maryla-uc approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@maryla-uc maryla-uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

wantehchang
wantehchang previously requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yannis: I only reviewed the public header avif.h. I suggest a change in anticipation of the libavif 1.0.0 release.

include/avif/avif.h Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
wantehchang
wantehchang reviewed Aug 22, 2023
View reviewed changes
include/avif/avif.h Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
@wantehchang wantehchang self-requested a review August 22, 2023 20:22
@wantehchang wantehchang dismissed their stale review August 22, 2023 20:22

Requested change has been made

@wantehchang wantehchang removed their request for review August 22, 2023 20:23
@y-guyon
Experimental reduced HEIF header
561b143 
Add AVIF_ENABLE_EXPERIMENTAL_AVIR flag.
Remove a few hundred bytes of container boilerplate for simple images.
This prototype uses a small box that expands in meaning to a full meta
box with all defined items and properties.

Warning: This feature is experimental and forbidden by the current
AVIF specification.
@y-guyon
Add avifConiColorType
1deb2cc
@y-guyon
Add TODO about NOT_IMPLEMENTED in ParseConi()
7eb013a
@y-guyon
Add hasExtendedMeta, hasExif and hasEXIF
68c6d77
@y-guyon
Add TODO in avifParse() about coni without avir
f301371
@y-guyon
Replace fallbacking by falling back
feef5d3
@y-guyon
Add assert(colorItem) in WriteFtypAndConi()
ed76df2
@y-guyon
Propagate avifRWStreamWrite*() status
cff7437 
Split avifEncoderWriteFileTypeBoxAndCondensedImageBox() into
avifEncoderWriteCondensedImageBox() for simpler extendedMeta freeing.
@y-guyon
Move headerStrategy to the end of avifEncoder
c5294bf
@y-guyon
Rename AVIF_ENCODER_MINIMIZE_HEADER by REDUCE
600ae72
@y-guyon
Add spec proposal ref to avifEncoderHeaderStrategy
958574a
@y-guyon
Add R to AVIF_ENCODER_REDUCE_HEADER
ff103e5
@y-guyon
Rename avifEncoderHeaderStrategy to Format
a69d90e
@y-guyon
Remove Encoder from avifEncoderHeaderFormat
9bc205d
@y-guyon
Add avifDiagnostics to avifconitest
e56255f 
Because of AOMediaCodec#1518
@y-guyon
Check result of WriteExtendedColorProperties()
89467bd
@y-guyon
Call WriteHDRProperties() in WriteExtendedMeta()
d225f28
@y-guyon
Add CHANGELOG entry
14043f2 
[skip ci]
@y-guyon
Fix comments and literals
19a8982
@y-guyon
Remove ABI changes from CHANGELOG.md
b5f297d
@y-guyon
Guard needsConi and coniSeen by AVIF_ENABLE_AVIR
fb4bce1
@y-guyon
Move headerFormat at the end of avifEncoderCreate
c1cf4d4
wantehchang
wantehchang approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yannis: I verified that the pull request is essentially a no-op if AVIF_ENABLE_EXPERIMENTAL_GAIN_MAP is not defined. I didn't review the code inside #if defined(AVIF_ENABLE_EXPERIMENTAL_AVIR).

Just three more minor comments.

include/avif/internal.h Show resolved Hide resolved
src/write.c Outdated Show resolved Hide resolved
src/write.c Outdated Show resolved Hide resolved
@y-guyon y-guyon merged commit 73510a1 into AOMediaCodec:main Sep 1, 2023
14 checks passed
@y-guyon y-guyon deleted the reduced_header branch September 1, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang wantehchang approved these changes

@maryla-uc maryla-uc maryla-uc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-guyon @wantehchang @maryla-uc