Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limited range support to FillImageGradient() #1494

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Add limited range support to FillImageGradient() #1494

merged 1 commit into from
Aug 11, 2023

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Aug 3, 2023

Also check clli, pasp, clap, irot and imir properties in AreImagesEqual().
Also move kSampleIcc, kSampleExif and kSampleXmp from avifmetadatatest.cc to aviftest_helpers.h.

This is partly to simplify #1432.

@y-guyon
Add limited range support to FillImageGradient()
5a77aeb 
Also check clli, pasp, clap, irot and imir properties in
AreImagesEqual().
Also move kSampleIcc, kSampleExif and kSampleXmp from
avifmetadatatest.cc to aviftest_helpers.h.
jzern
jzern approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@jzern jzern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is relatively small, but it could be broken up by each point in the commit message.

@y-guyon y-guyon merged commit 883e9c9 into AOMediaCodec:main Aug 11, 2023
14 checks passed
@y-guyon y-guyon deleted the fill_image_gradient_limited_range branch August 11, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzern jzern jzern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-guyon @jzern