Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STM32WLE5 for custom targets LORA_E5 and RAK3172 #14872

Merged
merged 8 commits into from
Jul 8, 2021
Merged

Add STM32WLE5 for custom targets LORA_E5 and RAK3172 #14872

merged 8 commits into from
Jul 8, 2021

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Jul 5, 2021 •
edited by 0xc0170
Loading

Added new CPU STM32WLE5 to prepare new custom lorawan boards based on modules with LoRa-E5 and RAK3172 targets
Replace #14859

Summary of changes

Impact of changes

Migration actions required

Documentation

Will allow to use new custom target now located at
https://github.com/ARMmbed/stm32customtargets

LORA_E5
RAK3172

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant @MarceloSalazar

@hallard hallard changed the title Stm32wl ex Add STM32WLE5 for custom targets Jul 5, 2021
@hallard hallard mentioned this pull request Jul 5, 2021
Closed
@hallard hallard changed the title Add STM32WLE5 for custom targets Add STM32WLE5 for custom targets LORA_E5 and RAK3172 Jul 5, 2021
@ciarmcom ciarmcom requested review from jeromecoutant, MarceloSalazar and a team July 5, 2021 11:30
@ciarmcom
Copy link
Member

ciarmcom commented Jul 5, 2021

@hallard, thank you for your changes.
@jeromecoutant @MarceloSalazar @ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

jeromecoutant
jeromecoutant reviewed Jul 6, 2021
View reviewed changes
targets/targets.json Outdated
@@ -4381,6 +4381,23 @@
],
"device_name": "STM32WL55JCIx"
},
"MCU_STM32WLe5xC": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WLE5, not WLe5 ?
Thx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

tools/arm_pack_manager/index.json
@@ -480222,6 +480222,74 @@
]
],
"sub_family": "STM32WL55"
},
"STM32WLE5JCIx": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding also STM32WLE5CCUx for RAK3172 could be a good idea ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, that's done

targets/targets.json Outdated
"extra_labels_add": [
"STM32WLE5xC"
],
"device_name": "STM32WLE5JCIx",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device_name can not be defined at this STM32WLe5xC level.
This information can be only added in the target level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tools/arm_pack_manager/index.json
"from_pack": {
"vendor": "Keil",
"pack": "STM32WLxx_DFP",
"version": "1.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, it's fixed, may be should be also done for WL55 (nucleo)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not mandatory, as MCU from NUCLEO was already available in 1.0.0, I think

@jeromecoutant
Copy link
Collaborator

FYI: @farrenv

@mergify mergify bot added needs: CI and removed needs: review labels Jul 7, 2021
jeromecoutant added a commit to ARMmbed/stm32customtargets that referenced this pull request Jul 7, 2021
@jeromecoutant
custom_targets.json : remove unsupported targets
66f13ae 
Waiting for ARMmbed/mbed-os#14872
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release-type: feature labels Jul 8, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 8, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 7350b03 into ARMmbed:master Jul 8, 2021
@mergify mergify bot removed the ready for merge label Jul 8, 2021
@hallard hallard deleted the STM32WLEx branch July 8, 2021 15:47
@jeromecoutant
Copy link
Collaborator

Seems TARGET_STM32WLE5xC is missing there:
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32WL/CMakeLists.txt#L4
:-(

@hallard hallard restored the STM32WLEx branch July 8, 2021 16:38
@hallard
Copy link
Contributor Author

hallard commented Jul 8, 2021

Sorry about that, do you want me to PR?

@jeromecoutant jeromecoutant mentioned this pull request Jul 9, 2021
Merged
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
component: tools devices: st release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hallard @ciarmcom @jeromecoutant @0xc0170 @mbed-ci @MarceloSalazar @mbedmain