[NUCLEO_F091RC] add I2C master asynch #1782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,8 @@ | |||
|
|
|||
| #define DEVICE_I2C 1 | |||
| #define DEVICE_I2CSLAVE 1 | |||
| #define DEVICE_I2C_ASYNCH 1 | |||
| #define DEVICE_I2C_ASYNCH_DMA 1 | |||
There was a problem hiding this comment.
Can you please rebase on top of master, to get features, and this would require to be updated then ?
|
Any update for this one and #1791 ? To rebase, use features, and fix formatting within the HAL files (nitpicks above). |
|
@dbestm Is there any update for this, I left some comments above, about rebasing this on top of the master to get this aligned (apart from some nits). |
|
Same comment as #1791 |
|
This PR is obsolete and can be closed. A new PR will replace it. |
|
@dbestm Closing this given it needs a lot of work please re-open when the conflicts are resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.