[NUCLEO_F401RE] add I2C master asynch #1791
Conversation
set with DMA by default in device.h
| __HAL_UNLOCK(&t_I2cHandle[i2c_module_lookup(obj)]); | ||
| } | ||
|
|
||
| __HAL_I2C_DISABLE_IT(&t_I2cHandle[i2c_module_lookup(obj)], I2C_IT_EVT|I2C_IT_ERR|I2C_IT_BUF); |
There was a problem hiding this comment.
there are some misalignment in the file like on this line, are there tabs ?
Look at line 1080 for instance, and others, please align the code properly. Use 4 spaces (reason: mbed style, it has been applied to this file)
| int use_tx = (tx != NULL && tx_length > 0); | ||
| int use_rx = (rx != NULL && rx_length > 0); | ||
|
|
||
| obj->tx_buff.buffer = (uint8_t *)malloc(8*tx_length); |
There was a problem hiding this comment.
Can you elaborate ? why do you allocate a new buffer and copy the data? And only for TX?
|
@dbestm Is there any update for this, I left some comments above. There is a conflict with master now, will require a rebase to resolve them. |
|
Hi Martin, I'm taking the point back. Most likely we'll close this PR and submit brand new PR. |
|
You should be able to close it ;) IF not ,let us know |
|
This PR is obsolete and can be closed. PR #2622 replaces this one. |
|
Closing give #2622 has been merged |
report__2016-05-26_11.12.48.25__NUCLEO_F401RE__i2c_master_asynch__GCC.html.zip