-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Sara-N NBIoT platform. #2705
Conversation
Is the CI stuck? |
@RobMeades Nope, all CI looks ok. I'll run one last check to be sure nothing else got broken in the process. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 873 All builds and test passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of comments about licenses and code style guidelines. Please review
@@ -0,0 +1,67 @@ | |||
/****************************************************************************** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what license is this under?
@@ -0,0 +1,22 @@ | |||
/****************************************************************************** | |||
* @brief BOUDICA Platform Header | |||
* Copyright (c) 2015 NEUL LIMITED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What license?
@@ -0,0 +1,13 @@ | |||
/****************************************************************************** | |||
* @brief Contains a define telling the rest of the code which core this is | |||
* Copyright (c) 2015 NEUL LIMITED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license check?
@@ -0,0 +1,504 @@ | |||
/****************************************************************************** | |||
* @brief Register map for the boudica Apps core | |||
* Copyright (c) 2015 NEUL LIMITED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license check
@@ -0,0 +1,60 @@ | |||
/****************************************************************************** | |||
* @brief BOUDICA Common peripheral Types and Register Flags Definitions Header | |||
* Copyright (c) 2015 NEUL LIMITED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license check?
{ | ||
MBED_ASSERT(pin != (PinName)NC); | ||
|
||
switch (mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obj->reg_drv = &GPIO_DRIVE; | ||
|
||
/* Claim the pins */ | ||
for (uint8_t x = 0; x < NUM_PINS; x++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
void port_mode(port_t *obj, PinMode mode) | ||
{ | ||
switch (mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* ----------------------------------------------------------------*/ | ||
|
||
/* Enum to identify the interrupt to the UART handler */ | ||
typedef enum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* Timer0 handler */ | ||
void IRQ1_TMR0_Handler(void) | ||
{ | ||
if (g_initialised) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will move to the difficult to read K&R style for my braces and obtain a LICENSE.TXT for those files. |
thanks and this should only need to apply to mbed integration files or files part of mbed OS. I tried to comment appropriately so should be all of certain directories. Any SDK, MCU or other files can maintain whichever formatting based on the project it comes from. |
Thanks @RobMeades Can you squash these to one commit and I'll run through another review! |
@sg: had to rebase due to usual RTX file conflicts, now need to debug what's got broken... |
Notes:
Re-integrated on a completely fresh pull and only one step ahead of HEAD. Nothing can fail this time due to a merge problem.
Description
mbed test -c
) for its small memory configuration (aside from a C librarynano.spec
float non-compliance which I have no control over, the newrace_test
, which is a multi-threaded test and hence not applicable to the small memory configuration, and an issue with thelp
sleep tests, which I'm looking at but don't want to gate this submission). Hence I would like to introduce it into the main mbed stream so that it doesn't fall behind in future developments.htrun
have been included to allow code loading and target reset with a Segger J-Link box. If this pull request is accepted, I will submit those hook files to thehtrun
repository also.Status
IN DEVELOPMENT
Migrations
None.
Related PRs
None.
Todos
lp
sleep tests.Deploy notes
This release not for general use, simply to join the workflow.
Steps to test or reproduce
In order to run the
htrun
tests you will need access to some tools that are stored in a private repo. The current test status is as follows: