-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add u-blox Sara-N target. #3011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good. There are some switch statements that use braces (violate SDK code style) for hal implementation and I think @bridadan @mazimkhan need to provide guidance on the htrun modifications.
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 Build failed! |
@sg: never heard of a coding standard forbidding braces before. Surely removing the braces will make things less clear, not more clear? |
Will work on getting these unified in one location but there should be a tool you can run and a format file and this particularly relates to mbed C hal integration and common code https://developer.mbed.org/teams/SDK-Development/wiki/mbed-sdk-coding-style https://docs.mbed.com/docs/getting-started-mbed-os/en/latest/Full_Guide/Code_Style/ https://docs.mbed.com/docs/mbed-os-handbook/en/5.1/cont/code_style/ |
Braces removed and pull request re-based. Really hoping to get this in now... |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 Build failed! |
What is the failure of ci/morph-test telling me? Do I need to rebase to head again? |
The failure occurred when trying to build the tests for the target using IAR:
In CI we add the following macros to the compile step to turn on some metrics:
Perhaps this is adding enough of a memory overhead that it's causing the build to fail? Can you confirm the tests compile OK with IAR without those macros added? |
Looks like it wants 20 kbytes of RAM for that build configuration and I only have just under 20 kbytes in total. I wonder how the Nordic 8K/16K platforms deal with that? I will take a look tomorrow and re-merge/fix. |
@bridadan any comment on what I should be about the |
@RobMeades The files you've added will not be used by Since the hardware isn't available for this board yet, I don't have too much of a problem with this coming in without a way (or I guess a custom way) to test it, especially if you're just trying to enforce that the build doesn't get broken. @sg- thoughts? |
In that case I will reverse-out the hook file changes here and apply them to the |
IAR issue fixed, |
Darn it, can someone (@bridadan , @sg- ) let me know what |
I removed an errant newline accidentally left in an otherwise unchanged file and now |
retest uvisor |
@RobMeades Thanks for your patience, the CI bots can sometimes fail due to infrastructure issues, so its not always a direct issue with the PR. I'll go ahead and run the last bot here. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 All builds and test passed! |
"public": false, | ||
"target_overrides": { | ||
"*": { | ||
"core.stdio-flush-at-exit": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobMeades This should be platform.stdio-flush-at-exit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sg- Do you want me to change this now before you merge, or can I do it safely later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later is fine give CI passes. Just a comment to make sure you get the advantage of the setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks.
Release mbed OS 5.2.2 and mbed lib v129 Known issues in this release There is currently a DNS resolution failure in Thread mode with this release. This causes a failure in the mbed-os-example-client. This will be fixed in a subsequent release. This can be worked around by reverting to mbed-os-5.2.0 Ports for Upcoming Targets 3011: Add u-blox Sara-N target. ARMmbed#3011 3099: MAX32625 ARMmbed#3099 3151: Add support for FRDM-K82F ARMmbed#3151 3177: New mcu k22512 fixing pr 3136 ARMmbed#3177 Fixes and Changes 2990: [tools] Parallel building of tests ARMmbed#2990 3008: NUCLEO_F072RB: Fix wrong timer channel number on pwm PB_5 pin ARMmbed#3008 3013: STM32xx - Change how the ADC internal pins are checked before pinmap_ ARMmbed#3013 3023: digital_loop tests update for STM32 ARMmbed#3023 3041: [nRF5] - added implementation of API of serial port flow control configuration. ARMmbed#3041 3092: [tools + tests] Adding parallelized build option for iar and uvision exporters ARMmbed#3092 3084: [nrf5] fix in Digital I/O : a gpioe pin was uninitialized badly ARMmbed#3084 3009: TRNG enabled. TRNG APIs implemented. REV A/B/C/D flags removed. Warnings removed ARMmbed#3009 3139: Handle [NOT_SUPPORTED] exception in make.py ARMmbed#3139 3074: Target stm init gcc alignement ARMmbed#3074 3140: [tests] Replacing getchar with RawSerial getc in greentea-client ARMmbed#3140 3158: Added support for 6lowpan PAN ID filter to mbed mesh api configuration ARMmbed#3158 2988: Update of can_api.c fixing ARMmbed#2987 ARMmbed#2988 3175: Updating IAR definition for the NCS36510 for IAR EW v7.8 ARMmbed#3175 3170: [tests] Preventing test from printing before Greentea __sync ARMmbed#3170 3169: [Update of ARMmbed#3014] Usb updates ARMmbed#3169 3143: CFStore fix needed for the Cloud Client ARMmbed#3143 3135: lwip - Fix memory leak in k64f cyclic-buffer overflow ARMmbed#3135 3048: Make update.py test compile examples prior to updating mbed-os version. ARMmbed#3048 3162: lwip/nsapi - Clean up warnings in network code ARMmbed#3162 3161: nsapi - Add better heuristic for the default record of DNS queries ARMmbed#3161 3173: [Exporters] Add a device_name to microbit entry in targets.json ARMmbed#3173 3072: i2c_loop tests update for STM32 ARMmbed#3072 2958: Allowing mbed_app.json files to be discovered for tests. ARMmbed#2958 2969: [nRF52] - switch irq priorities of driver handlers to the lowest level ARMmbed#2969 3078: lwip: Allow several configuration macros to be set externally (bis) ARMmbed#3078 3165: Add address type checks to NanostackInterface ARMmbed#3165 3166: nsapi_dns: Provide 2 IPv6-hosted default servers ARMmbed#3166 3171: [tools] Fixing project.py -S printing problem ARMmbed#3171 3172: [Exporters] New export-build tests ARMmbed#3172 3184: ARMmbed#3183 Compiler warning in trng_api.c with K64F ARMmbed#3184 3185: Update tests to fix build failures. Also make the code similar to oth ARMmbed#3185 3104: [NuMaker] Support CAN and fix PWM CLK error ARMmbed#3104 3182: Exporter documentation ARMmbed#3182 3186: MultiTech mDot - add back SPI3 pins ARMmbed#3186 3187: [Export-Make] Use internal class variable for resolving templates in makefiles ARMmbed#3187 3195: [Exporters - Make-based] Quote the shell call in mkdir and rmdir ARMmbed#3195 3204: [Export build-test] Directory traversal error ARMmbed#3204 3189: [Exporters - Make-based] Force make exporter to search PATH for compilers ARMmbed#3189 3200: Using Popen for uVision and unifying the structure of the build function ARMmbed#3200 3075: nsapi - Add standardized return types for size and errors ARMmbed#3075 3221: u-blox odin w2 drivers update ARMmbed#3221
Ports for Upcoming Targets 3011: Add u-blox Sara-N target. ARMmbed/mbed-os#3011 3099: MAX32625 ARMmbed/mbed-os#3099 3151: Add support for FRDM-K82F ARMmbed/mbed-os#3151 3177: New mcu k22512 fixing pr 3136 ARMmbed/mbed-os#3177 Fixes and Changes 3008: NUCLEO_F072RB: Fix wrong timer channel number on pwm PB_5 pin ARMmbed/mbed-os#3008 3013: STM32xx - Change how the ADC internal pins are checked before pinmap_ ARMmbed/mbed-os#3013 3041: [nRF5] - added implementation of API of serial port flow control configuration. ARMmbed/mbed-os#3041 3084: [nrf5] fix in Digital I/O : a gpioe pin was uninitialized badly ARMmbed/mbed-os#3084 3009: TRNG enabled. TRNG APIs implemented. REV A/B/C/D flags removed. Warnings removed ARMmbed/mbed-os#3009 3074: Target stm init gcc alignement ARMmbed/mbed-os#3074 2988: Update of can_api.c fixing #2987 ARMmbed/mbed-os#2988 3173: [Exporters] Add a device_name to microbit entry in targets.json ARMmbed/mbed-os#3173 2969: [nRF52] - switch irq priorities of driver handlers to the lowest level ARMmbed/mbed-os#2969 3184: #3183 Compiler warning in trng_api.c with K64F ARMmbed/mbed-os#3184 3104: [NuMaker] Support CAN and fix PWM CLK error ARMmbed/mbed-os#3104 3186: MultiTech mDot - add back SPI3 pins ARMmbed/mbed-os#3186 3075: nsapi - Add standardized return types for size and errors ARMmbed/mbed-os#3075 3221: u-blox odin w2 drivers update ARMmbed/mbed-os#3221
Description
mbed test -c
). Hence I would like to introduce it into the main mbed stream so that it doesn't fall behind in future developments.htrun
will be submitted separately to thehtrun
repository to allow code loading and target reset with a Segger J-Link box.Status
IN DEVELOPMENT
Migrations
None.
Related PRs
Previous attempt to get this into the flow was in pull request #2705.
Todos
Add drivers for more peripherals (ASYNC, SPI, I2C, PWM, ADC).
Deploy notes
This release not for general use, simply to join the workflow.
Steps to test or reproduce
In order to run the
htrun
tests you will need access to some tools that are stored in a private repo. The current test status is as follows: