-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files #3316
Conversation
Gotta love that diff! Nice work @jeromecoutant 😄 /morph test |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
Sorry for the abort, I forgot the normal tests don't touch the LP timers. Starting a full nightly now. /morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
@mbed-bot: TEST HOST_OSES=ALL |
[Build 1144] |
int rtc_isenabled(void) | ||
{ | ||
#if DEVICE_LOWPOWERTIMER | ||
if ((RTC->ISR & RTC_ISR_INITS) == RTC_ISR_INITS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be as it was if () {
, starting { on the same line
RCC_OscInitStruct.LSIState = RCC_LSI_OFF; | ||
|
||
if (HAL_RCC_OscConfig(&RCC_OscInitStruct) == HAL_OK) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, the code style
Bump |
I ran astyle script |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
We should run the nightly on this so the LP ticker tests are ran. /morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
I've sent the replacement #3454 that is rebased on top of master to resolve CI issue we are seeing. I'll close this one |
Description
The goal of this PR is to refactor 4 files :
Now only 4 files are used for all the STM32 devices and placed in TARGET_STM folder
Status
READY
Test status
OS2 and OS5 Tests have been checked with all family targets