Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files #3454

Merged
merged 2 commits into from
Dec 23, 2016
Merged

STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files #3454

merged 2 commits into from
Dec 23, 2016

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Dec 16, 2016

Rebased #3316 . PLease see the referenced PR for more details. No conflicts, just rebased on top of latest master. This should fix one failure in the CI we saw

cc @jeromecoutant

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 16, 2016

/morph test

@0xc0170 0xc0170 mentioned this pull request Dec 16, 2016
Closed
@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1280

All builds and test passed!

@bridadan
Copy link
Contributor

@VeliMattiLahtela Could you please comment on the CI failure? I did my best to track down where the actual problem was, and it looks like its occuring in the mbed-os-cliapp.

Based on this log: https://jenkins-internal.mbed.com/job/ARMmbed/job/mbed-os-cliapp/job/master/1679/execution/node/2793/log/?consoleFull

After running the following command:

python clitest.py --suitedir testcases/suites/ --suite K64F_armcc_wlan0.json --type hardware --reset --raas 193.208.80.31:8022 --failure_return_value -vvv -w --log log_8022

There was a failure:

12:30:45 TC creation failed
12:30:45 +---------------------+---------+--------------------------------+-------------+-----------+
12:30:45 | Testcase            | Verdict |          Fail Reason           | Skip Reason |  duration |
12:30:45 +---------------------+---------+--------------------------------+-------------+-----------+
12:30:45 | boot_smoke_test     |   pass  |                                |             | 40.290588 |
12:30:45 | interface_up_down   |   pass  |                                |             | 22.843215 |
12:30:45 | basic_dns_TCP       |   pass  |                                |             | 17.449872 |
12:30:45 | basic_dns_UDP       |   fail  | D1 CMD timeout: ntp --if wlan0 |             | 65.841998 |
12:30:45 | socket_resolve_host |   pass  |                                |             | 18.914923 |
12:30:45 +---------------------+---------+--------------------------------+-------------+-----------+
12:30:45 +---------------+----------------+
12:30:45 |    Summary    |                |
12:30:45 +---------------+----------------+
12:30:45 | Final Verdict |      FAIL      |
12:30:45 |     count     |       5        |
12:30:45 |      pass     |       4        |
12:30:45 |      fail     |       1        |
12:30:45 |    Duration   | 0:02:45.340596 |
12:30:45 +---------------+----------------+

We can't merge this PR (or any other PRs on mbed OS) until this is resolved, could you please take a look?

@jeromecoutant
Copy link
Collaborator

Can I help ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 20, 2016

Can I help ?

Please rebase to resolve conflict above. The Ci was resolved, shoudl be green now (once conflict is resolved)

@jeromecoutant
Copy link
Collaborator

Please rebase to resolve conflict above.

It seems that I can't as PR is now on your repo...

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 21, 2016

Correct, will rebase soon. Thanks

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 21, 2016

Rebased

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1313

All builds and test passed!

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 22, 2016

@jeromecoutant I rebased it. there was one conflict (rtc_api). Please can you review if all correct, should be.

@0xc0170 0xc0170 merged commit d652d39 into ARMmbed:master Dec 23, 2016
@0xc0170 0xc0170 deleted the jeromecoutant-PR_LPT branch December 23, 2016 13:06
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Release 133 of the mbed library
f622120 
Ports for Upcoming Targets

3459: Target: Add new target UBLOX_EVK_NINA_B1 ARMmbed/mbed-os#3459

Fixes and Changes

3430: Fix ci shield eeprom test ARMmbed/mbed-os#3430
3381: STM32F1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3381
3389: STM32F2 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3389
3390: STM32F3 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3390
3410: STM32L4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3410
3422: Enable CAN on DISCO_F303VC ARMmbed/mbed-os#3422
3442: Dev stm i2c f1 ARMmbed/mbed-os#3442
3460: KSDK I2C: Update the return value to match the API documentation change ARMmbed/mbed-os#3460
3472: [RZ/A1H]Fix TTB setting of RO_DATA area ARMmbed/mbed-os#3472
3451: Rename KSDK2 to MCUXpresso. This is the new name of this package ARMmbed/mbed-os#3451
3391: STM32F4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3391
3454: STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files  ARMmbed/mbed-os#3454
3489: NUCLEO_F103RB - Correct CAN and PWM alternate-functions ARMmbed/mbed-os#3489
3405: Repair the transmit mailbox (0,1,2) empty interrupt flag not clear BUG ARMmbed/mbed-os#3405
3502: MCUXpresso I2C: Handle 0 byte write ARMmbed/mbed-os#3502
3365: [NUC472/M453] Support USB device ARMmbed/mbed-os#3365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xc0170 @mbed-bot @bridadan @jeromecoutant