Fix ci shield eeprom test #3430

LMESTM · 2016-12-12T16:28:35Z

Description

With ci test shiled tests, a few issues were faced and needed to be solved

the reference I2C test makes a mixed usage for unitary MBED APIs (start / stop / send & read bytes) and more advanced read and write APIs which autonomously manage start and stop. The code needed update to cope with this API use.
also the eeprom driver checks if eeprom is ready by sending data of length = 0, the STM32 HAL provides a dedicated API for such case which we're using now

This allows to have the I2C eeprom test to pass on F1, F2, F4 and L1 families.

Other families have not passed the tests yet - further work is needed as they embed a different I2C IP version - this will be done in a later PR.

Status

READY

+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-api-i2c | I2C - EEProm WR 10 Bytes | 1 | 0 | OK | 0.06 |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-api-i2c | I2C - EEProm WR 100 Bytes | 1 | 0 | OK | 0.08 |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-api-i2c | I2C - EEProm WR 2 Bytes | 1 | 0 | OK | 0.05 |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-api-i2c | I2C - EEProm WR Single Byte | 1 | 0 | OK | 0.07 |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-api-i2c | I2C - Instantiation of I2C Object | 1 | 0 | OK | 0.07 |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-api-i2c | I2C - LM75B Temperature Read | 1 | 0 | OK | 0.06 |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-api-i2c | I2C - EEProm WR 10 Bytes | 1 | 0 | OK | 0.07 |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-api-i2c | I2C - EEProm WR 100 Bytes | 1 | 0 | OK | 0.05 |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-api-i2c | I2C - EEProm WR 2 Bytes | 1 | 0 | OK | 0.07 |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-api-i2c | I2C - EEProm WR Single Byte | 1 | 0 | OK | 0.06 |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-api-i2c | I2C - Instantiation of I2C Object | 1 | 0 | OK | 0.06 |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-api-i2c | I2C - LM75B Temperature Read | 1 | 0 | OK | 0.07 |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| NUCLEO_L152RE-ARM | NUCLEO_L152RE | tests-api-i2c | I2C - EEProm WR 10 Bytes | 1 | 0 | OK | 0.07 |
| NUCLEO_L152RE-ARM | NUCLEO_L152RE | tests-api-i2c | I2C - EEProm WR 100 Bytes | 1 | 0 | OK | 0.08 |
| NUCLEO_L152RE-ARM | NUCLEO_L152RE | tests-api-i2c | I2C - EEProm WR 2 Bytes | 1 | 0 | OK | 0.06 |
| NUCLEO_L152RE-ARM | NUCLEO_L152RE | tests-api-i2c | I2C - EEProm WR Single Byte | 1 | 0 | OK | 0.06 |
| NUCLEO_L152RE-ARM | NUCLEO_L152RE | tests-api-i2c | I2C - Instantiation of I2C Object | 1 | 0 | OK | 0.06 |
| NUCLEO_L152RE-ARM | NUCLEO_L152RE | tests-api-i2c | I2C - LM75B Temperature Read | 1 | 0 | OK | 0.05 |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+
| NUCLEO_F446ZE-ARM | NUCLEO_F446ZE | tests-api-i2c | I2C - EEProm WR 10 Bytes | 1 | 0 | OK | 0.07 |
| NUCLEO_F446ZE-ARM | NUCLEO_F446ZE | tests-api-i2c | I2C - EEProm WR 100 Bytes | 1 | 0 | OK | 0.06 |
| NUCLEO_F446ZE-ARM | NUCLEO_F446ZE | tests-api-i2c | I2C - EEProm WR 2 Bytes | 1 | 0 | OK | 0.06 |
| NUCLEO_F446ZE-ARM | NUCLEO_F446ZE | tests-api-i2c | I2C - EEProm WR Single Byte | 1 | 0 | OK | 0.06 |
| NUCLEO_F446ZE-ARM | NUCLEO_F446ZE | tests-api-i2c | I2C - Instantiation of I2C Object | 1 | 0 | OK | 0.06 |
| NUCLEO_F446ZE-ARM | NUCLEO_F446ZE | tests-api-i2c | I2C - LM75B Temperature Read | 1 | 0 | OK | 0.06 |
+-------------------+---------------+---------------+------------------------------------+--------+--------+--------+--------------------+

bridadan · 2016-12-12T18:51:11Z

Could you please take a look @0xc0170?

/morph test

bridadan · 2016-12-12T18:51:37Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-12-12T19:49:14Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1254

All builds and test passed!

mbed-bot · 2016-12-12T20:08:20Z

[Build 1164]
FAILURE: Something went wrong when building and testing.

bridadan · 2016-12-12T20:10:13Z

The continuous-integration/mbedci job failed due to a CI machine failure. Restarting the job now

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-12-12T20:20:57Z

[Build 1165]
FAILURE: Something went wrong when building and testing.

bridadan · 2016-12-12T20:23:29Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-12-12T23:55:44Z

[Build 1166]
FAILURE: Something went wrong when building and testing.

bridadan · 2016-12-13T00:44:22Z

Failure was due to a K64F being knocked out by DAPLink testing, oops! Everything else looked OK, rerunnng just the K64F now.

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=K64F

mbed-bot · 2016-12-13T00:56:41Z

[Build 1167]
FAILURE: Something went wrong when building and testing.

BlackstoneEngineering · 2016-12-13T00:59:00Z

#citestshieldforthewin

0xc0170 · 2016-12-13T09:40:17Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=K64F

mbed-bot · 2016-12-13T10:12:40Z

[Build 1169]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

sg- · 2016-12-15T16:36:13Z

@LMESTM Can you resolve the conflict? thx!

just change the place of code to have i2c_read and i2c_write together

Some device drivers use a data lenght of 0 to check if device is ready. STM32 HAL provides a dedicated service for that, so let's use it.

In continuation of previous IsDeviceReady case, let's add 1 in case length is 0 (even though not recommended)

In case the user applicaiton makes a mixed usage of unitary function (start, stop, byte write & read) with SYNC operation (write and read of data buffers with start and stop management), we need to reset the STM32 HAL state as it is by-passed by a direct call to STOP

LMESTM · 2016-12-16T07:59:23Z

@sg- Rebase done

bridadan · 2016-12-16T15:13:00Z

/morph test

mbed-bot · 2016-12-16T16:22:41Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1282

All builds and test passed!

Ports for Upcoming Targets 3459: Target: Add new target UBLOX_EVK_NINA_B1 ARMmbed/mbed-os#3459 Fixes and Changes 3430: Fix ci shield eeprom test ARMmbed/mbed-os#3430 3381: STM32F1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3381 3389: STM32F2 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3389 3390: STM32F3 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3390 3410: STM32L4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3410 3422: Enable CAN on DISCO_F303VC ARMmbed/mbed-os#3422 3442: Dev stm i2c f1 ARMmbed/mbed-os#3442 3460: KSDK I2C: Update the return value to match the API documentation change ARMmbed/mbed-os#3460 3472: [RZ/A1H]Fix TTB setting of RO_DATA area ARMmbed/mbed-os#3472 3451: Rename KSDK2 to MCUXpresso. This is the new name of this package ARMmbed/mbed-os#3451 3391: STM32F4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3391 3454: STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files ARMmbed/mbed-os#3454 3489: NUCLEO_F103RB - Correct CAN and PWM alternate-functions ARMmbed/mbed-os#3489 3405: Repair the transmit mailbox (0,1,2) empty interrupt flag not clear BUG ARMmbed/mbed-os#3405 3502: MCUXpresso I2C: Handle 0 byte write ARMmbed/mbed-os#3502 3365: [NUC472/M453] Support USB device ARMmbed/mbed-os#3365

bridadan added needs: CI needs: review labels Dec 12, 2016

0xc0170 approved these changes Dec 13, 2016

View reviewed changes

0xc0170 removed the needs: review label Dec 13, 2016

0xc0170 added ready for merge and removed needs: CI labels Dec 13, 2016

LMESTM mentioned this pull request Dec 14, 2016

Dev stm i2c f1 #3442

Merged

LMESTM added 4 commits December 16, 2016 08:54

STM I2C - move i2c_read in SYNC part

c0ca0a7

just change the place of code to have i2c_read and i2c_write together

STM I2C: manage Is Device Ready case

37c94a0

Some device drivers use a data lenght of 0 to check if device is ready. STM32 HAL provides a dedicated service for that, so let's use it.

STM32 I2C: avoid timeout to be 0

8406a99

In continuation of previous IsDeviceReady case, let's add 1 in case length is 0 (even though not recommended)

LMESTM force-pushed the fix_ci_shield_eeprom_test branch from e72eef0 to 580d964 Compare December 16, 2016 07:59

adbridge added the release-version: 5.3.2 label Dec 19, 2016

adbridge removed the ready for merge label Dec 19, 2016

adbridge merged commit 1219f88 into ARMmbed:master Dec 19, 2016

LMESTM deleted the fix_ci_shield_eeprom_test branch February 27, 2017 10:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ci shield eeprom test #3430

Fix ci shield eeprom test #3430

LMESTM commented Dec 12, 2016

bridadan commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

bridadan commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

BlackstoneEngineering commented Dec 13, 2016

0xc0170 commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

sg- commented Dec 15, 2016

LMESTM commented Dec 16, 2016

bridadan commented Dec 16, 2016

mbed-bot commented Dec 16, 2016

Fix ci shield eeprom test #3430

Fix ci shield eeprom test #3430

Conversation

LMESTM commented Dec 12, 2016

Description

Status

bridadan commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

Result: SUCCESS

Output

mbed-bot commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 12, 2016

bridadan commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

BlackstoneEngineering commented Dec 13, 2016

0xc0170 commented Dec 13, 2016

mbed-bot commented Dec 13, 2016

sg- commented Dec 15, 2016

LMESTM commented Dec 16, 2016

bridadan commented Dec 16, 2016

mbed-bot commented Dec 16, 2016

Result: SUCCESS

Output