IDE Export support for platform VK_RZ_A1H #3632

mbedNoobNinja · 2017-01-24T11:04:07Z

IAR, DS5 & e2studio

mbedNoobNinja · 2017-01-24T11:56:16Z

Just a question: Why in the mbed online compiler neither RZ_A1H nor VK_RZ_A1H can be compiled successfuly but if they are compiled offline (after checkout and execution of build.py ) there is no problem?

0xc0170 · 2017-01-24T12:01:08Z

Just a question: Why in the mbed online compiler neither RZ_A1H nor VK_RZ_A1H can be compiled successfuly but if they are compiled offline (after checkout and execution of build.py ) there is no problem?

please report this as an issue, with detailed description (to be able to reproduce it)

0xc0170 · 2017-01-24T14:01:24Z

targets/targets.json

@@ -1831,7 +1831,8 @@
        "device_has": ["ANALOGIN", "CAN", "ERROR_PATTERN", "ETHERNET", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_FC", "SPI", "SPISLAVE", "STDIO_MESSAGES"],
        "features": ["LWIP"],
        "default_lib": "std",
-        "release_versions": ["2", "5"]
+        "release_versions": ["2", "5"],
+	"device_name": "r7s721000"


can you align this line and same for ds5_5.py edit?

theotherjimmy

Be aware of #3601.

theotherjimmy · 2017-01-24T14:29:24Z

Also, be aware that exporter updates will affect the online system at the earliest after a release.

mbedNoobNinja · 2017-01-24T16:12:02Z

The files are aligned! but no idea what to do with #3601. For the earlier releases it just won't work!

theotherjimmy · 2017-01-24T18:41:03Z

Don't worry about it, unless it comes in first. Then I'll tell you what needs to change. It was a note for myself.

bridadan · 2017-01-25T07:40:43Z

targets/TARGET_RENESAS/TARGET_VK_RZ_A1H/gpio_irq_api.c

@@ -71,6 +71,7 @@ static const PinMap PinMap_IRQ[] = {
 #else
 static const PinMap PinMap_IRQ[] = {
    {P9_1,  IRQ0, 4},
+    {P7_8,  IRQ1, 8},


Is this change related?

should not be

It is forgotten external Interrupt pin, which was missed at the creation of the SDK for that platform.

Could you move it into another PR? We can get both in faster if they are smaller and more targeted.

I don't know how, if I make another pull request basically the two PR will be the same but with different headlines.

Basically, you pull the other commit into another branch. Due to the history here, this can get a bit complicated e.g.

# Make a new branch git checkout origin/master -b add-rz-pins # Move the changes from the first commit onto the branch, without making a commit git cherry-pick -n aede40f529a7d433000dd84d9535e41e3015b2be # Remove unrelated changes git reset HEAD targets/targets.json tools/export/ds5_5.py tools/export/ds5_5_vk_rz_a1h.cproject.tmpl tools/export/ds5_5_vk_rz_a1h.launch.tmpl tools/export/ds5_5_vk_rz_a1h.project.tmpl tools/export/e2studio.py tools/export/e2studio_vk_rz_a1h_cproject.tmpl tools/export/e2studio_vk_rz_a1h_gdbinit.tmpl tools/export/e2studio_vk_rz_a1h_project.tmpl tools/export/iar/iar_definitions.json # Commit these changes git commit -m "Add missing pin to VK_RZ_A1H"

Or more simply

git checkout origin/master -b add-rz-pins # Now manually add the changes (the single line addition) git add targets/TARGET_RENESAS/TARGET_VK_RZ_A1H/gpio_irq_api.c git commit -m "Add missing pin to VK_RZ_A1H"

OK. The PR is created #3642

Nicely done!

Now could you remove the change from this change set?
e.g.

# start an interactive rebase git rebase -i origin/master # replace 'pick' from in front of 'Export IDE support added' with 'edit' # revert the file git reset HEAD^ targets/TARGET_RENESAS/TARGET_VK_RZ_A1H/gpio_irq_api.c # add the reverted file git add targets/TARGET_RENESAS/TARGET_VK_RZ_A1H/gpio_irq_api.c # modify the commit with the changes added git commit --amend # finish the rebase. git rebase --continue

Yeah it's done! sorry for the late response but I always have a hard time when dealing with git

It looks great! Thanks for rebasing and breaking the PR into two!

theotherjimmy · 2017-01-25T07:49:03Z

Hmmmm.... socket timeout on a K64F on the continuous-integration/jenkins/pr-head job... I don't think its related....

bridadan · 2017-01-25T12:56:55Z

/morph export-build

mbedNoobNinja · 2017-01-30T07:02:00Z

Wow 3 days and still building ... quite a long build ...

0xc0170 · 2017-01-30T13:48:29Z

Wow 3 days and still building ... quite a long build ...

we will restart CI, but first resolve conflicts. Can you?

mbedNoobNinja · 2017-01-30T14:17:54Z

Not exactly. I can't find the problem. Everything seems OK when these scripts are processed offline I mean through project.py (The export is working nicely without any complaint)

theotherjimmy · 2017-01-30T14:55:13Z

You should try to

git fetch origin
git rebase origin/master

mbedNoobNinja · 2017-01-30T15:46:01Z

Same result: successful build and export. Are you sure it must be origin? Should I try something with libraries, not just the blinky project.

theotherjimmy · 2017-01-30T15:48:40Z

Are you sure it must be origin?

I assumed that origin would be armmbed/mbed-os. But you should fetch whichever the remote that corresponds to and rebase with the same remote.

adbridge · 2017-01-30T16:35:42Z

@mbedNoobNinja please rebase to remove conflicts

theotherjimmy · 2017-01-30T16:37:30Z

We could use a needs: rebase tag. :D

mbedNoobNinja · 2017-01-30T17:12:08Z

Not sure this will help

theotherjimmy · 2017-01-30T17:22:01Z

The Cam-CI failure is a Java exception related to multi-threaded file access. Not your fault @mbedNoobNinja

theotherjimmy · 2017-01-30T17:22:38Z

@mbedNoobNinja We prefer a rebase to a merge commit. FYI.

mbedNoobNinja · 2017-01-31T08:39:33Z

OK, finally! Now it must be fine. (If you have not changed directories again :D)

0xc0170 · 2017-01-31T11:08:24Z

/morph export-build

mbed-bot · 2017-01-31T11:54:25Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 98

All exports and builds passed!

Ports for Upcoming Targets Fixes and Changes 3432: Target STM USBHOST support ARMmbed/mbed-os#3432 3181: NUCLEO_F207ZG extending PeripheralPins.c: all available alternate functions can be used now ARMmbed/mbed-os#3181 3626: NUCLEO_F412ZG : Add USB Device +Host ARMmbed/mbed-os#3626 3628: Fix warnings ARMmbed/mbed-os#3628 3629: STM32: L0 LL layer ARMmbed/mbed-os#3629 3632: IDE Export support for platform VK_RZ_A1H ARMmbed/mbed-os#3632 3642: Missing IRQ pin fix for platform VK_RZ_A1H ARMmbed/mbed-os#3642 3664: Fix ncs36510 sleep definitions ARMmbed/mbed-os#3664 3655: [STM32F4] Modify folder structure ARMmbed/mbed-os#3655 3657: [STM32L4] Modify folder structure ARMmbed/mbed-os#3657 3658: [STM32F3] Modify folder structure ARMmbed/mbed-os#3658 3685: STM32: I2C: reset state machine ARMmbed/mbed-os#3685 3692: uVisor: Standardize available legacy heap and stack ARMmbed/mbed-os#3692 3621: Fix for #2884, LPC824: export to LPCXpresso, target running with wron ARMmbed/mbed-os#3621 3649: [STM32F7] Modify folder structure ARMmbed/mbed-os#3649 3695: Enforce device_name is valid in targets.json ARMmbed/mbed-os#3695 3723: NCS36510: spi_format function bug fix ARMmbed/mbed-os#3723

0xc0170 requested a review from theotherjimmy January 24, 2017 11:24

0xc0170 added the needs: review label Jan 24, 2017

0xc0170 reviewed Jan 24, 2017

View reviewed changes

theotherjimmy approved these changes Jan 24, 2017

View reviewed changes

bridadan reviewed Jan 25, 2017

View reviewed changes

mbedNoobNinja mentioned this pull request Jan 25, 2017

Missing IRQ pin fix for platform VK_RZ_A1H #3642

Merged

mbedNoobNinja force-pushed the master branch from 75012ea to ccd51d7 Compare January 25, 2017 12:41

bridadan added the needs: CI label Jan 25, 2017

adbridge added the needs: work label Jan 30, 2017

Export IDE support added

d627bf2

mbedNoobNinja force-pushed the master branch from afad1f6 to d627bf2 Compare January 31, 2017 08:37

0xc0170 removed the needs: work label Jan 31, 2017

0xc0170 approved these changes Jan 31, 2017

View reviewed changes

0xc0170 removed the needs: review label Jan 31, 2017

0xc0170 added ready for merge and removed needs: CI labels Jan 31, 2017

sg- added release-version: 5.3.5 and removed ready for merge labels Feb 2, 2017

sg- merged commit dd9b645 into ARMmbed:master Feb 2, 2017

mbedNoobNinja mentioned this pull request Feb 14, 2017

Export malfunction of mbed online compiler ! #3768

Closed

phyokyaw mentioned this pull request Aug 23, 2017

e2 studio exporter update #4959

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IDE Export support for platform VK_RZ_A1H #3632

IDE Export support for platform VK_RZ_A1H #3632

mbedNoobNinja commented Jan 24, 2017

mbedNoobNinja commented Jan 24, 2017

0xc0170 commented Jan 24, 2017

0xc0170 Jan 24, 2017

theotherjimmy left a comment

theotherjimmy commented Jan 24, 2017

mbedNoobNinja commented Jan 24, 2017 •

edited

Loading

theotherjimmy commented Jan 24, 2017 •

edited

Loading

bridadan Jan 25, 2017

0xc0170 Jan 25, 2017 •

edited

Loading

mbedNoobNinja Jan 25, 2017

theotherjimmy Jan 25, 2017

mbedNoobNinja Jan 25, 2017

theotherjimmy Jan 25, 2017

mbedNoobNinja Jan 25, 2017

theotherjimmy Jan 25, 2017

mbedNoobNinja Jan 25, 2017

theotherjimmy Jan 25, 2017

theotherjimmy commented Jan 25, 2017

bridadan commented Jan 25, 2017

mbedNoobNinja commented Jan 30, 2017

0xc0170 commented Jan 30, 2017

mbedNoobNinja commented Jan 30, 2017

theotherjimmy commented Jan 30, 2017

mbedNoobNinja commented Jan 30, 2017 •

edited

Loading

theotherjimmy commented Jan 30, 2017

adbridge commented Jan 30, 2017

theotherjimmy commented Jan 30, 2017

mbedNoobNinja commented Jan 30, 2017 •

edited

Loading

theotherjimmy commented Jan 30, 2017

theotherjimmy commented Jan 30, 2017

mbedNoobNinja commented Jan 31, 2017 •

edited

Loading

0xc0170 commented Jan 31, 2017

mbed-bot commented Jan 31, 2017

IDE Export support for platform VK_RZ_A1H #3632

IDE Export support for platform VK_RZ_A1H #3632

Conversation

mbedNoobNinja commented Jan 24, 2017

mbedNoobNinja commented Jan 24, 2017

0xc0170 commented Jan 24, 2017

Choose a reason for hiding this comment

theotherjimmy left a comment

Choose a reason for hiding this comment

theotherjimmy commented Jan 24, 2017

mbedNoobNinja commented Jan 24, 2017 • edited Loading

theotherjimmy commented Jan 24, 2017 • edited Loading

Choose a reason for hiding this comment

0xc0170 Jan 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theotherjimmy commented Jan 25, 2017

bridadan commented Jan 25, 2017

mbedNoobNinja commented Jan 30, 2017

0xc0170 commented Jan 30, 2017

mbedNoobNinja commented Jan 30, 2017

theotherjimmy commented Jan 30, 2017

mbedNoobNinja commented Jan 30, 2017 • edited Loading

theotherjimmy commented Jan 30, 2017

adbridge commented Jan 30, 2017

theotherjimmy commented Jan 30, 2017

mbedNoobNinja commented Jan 30, 2017 • edited Loading

theotherjimmy commented Jan 30, 2017

theotherjimmy commented Jan 30, 2017

mbedNoobNinja commented Jan 31, 2017 • edited Loading

0xc0170 commented Jan 31, 2017

mbed-bot commented Jan 31, 2017

Output

mbedNoobNinja commented Jan 24, 2017 •

edited

Loading

theotherjimmy commented Jan 24, 2017 •

edited

Loading

0xc0170 Jan 25, 2017 •

edited

Loading

mbedNoobNinja commented Jan 30, 2017 •

edited

Loading

mbedNoobNinja commented Jan 30, 2017 •

edited

Loading

mbedNoobNinja commented Jan 31, 2017 •

edited

Loading