Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce device_name is valid in targets.json #3695

Merged
merged 3 commits into from
Feb 9, 2017

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Feb 3, 2017

Add a CI test ensure that device_name exists inside the pack index.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Feb 4, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Feb 4, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1502

All builds and test passed!

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

how we can fix those devices?

@adbridge
Copy link
Contributor

adbridge commented Feb 6, 2017

@mazimkhan

@mazimkhan
Copy link

retest uvisor

@c1728p9
Copy link
Contributor Author

c1728p9 commented Feb 7, 2017

@0xc0170 those devices just need a pack created for them and they can be added back.

@bridadan
Copy link
Contributor

bridadan commented Feb 7, 2017

Hang on a minute, this will remove IAR support for all of the devices you removed the device_name key. These devices don't have a PACK but they are still supported by IAR. Mainly the ones I'm worried about here are the RZ_A1H, the VK_RZ_A1H, and the NCS36510.

Edit: Here's the relevant section in the docs: https://github.com/ARMmbed/mbed-os/blob/master/docs/exporters.md#uvision-and-iar

@bridadan
Copy link
Contributor

bridadan commented Feb 7, 2017

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Feb 7, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 106

All exports and builds passed!

@bridadan
Copy link
Contributor

bridadan commented Feb 7, 2017

In the test results you can see that the RZ_A1H, VK_RZ_A1H, and the NCS36510 all stopped exporting to IAR. @c1728p9 we discussed offline a way forward on this, do you have what you need to make those changes?

@bridadan bridadan closed this Feb 7, 2017
@bridadan bridadan reopened this Feb 7, 2017
Allow the IAR exporter to fall back to a target's name if the
device_name entry is missing.
The field device_name is intended to match that of a target in a
device family pack. Remove this field for devices which do not have
a pack. Fix the name for devices that have the name incorrect. Update
IAR definitions for device which no longer have a device_name but
still need to have support for the IAR exporter.
Add a CI test ensure that device_name exists inside the pack index.
@c1728p9
Copy link
Contributor Author

c1728p9 commented Feb 8, 2017

/morph test

@c1728p9
Copy link
Contributor Author

c1728p9 commented Feb 8, 2017

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Feb 8, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1534

All builds and test passed!

@mbed-bot
Copy link

mbed-bot commented Feb 8, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 114

All exports and builds passed!

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results look ok to me 👍

@theotherjimmy
Copy link
Contributor

History looks good.

@sg- sg- merged commit 34de26d into ARMmbed:master Feb 9, 2017
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Ports for Upcoming Targets


Fixes and Changes

3432: Target STM USBHOST support ARMmbed/mbed-os#3432
3181: NUCLEO_F207ZG extending PeripheralPins.c: all available alternate functions can be used now ARMmbed/mbed-os#3181
3626: NUCLEO_F412ZG : Add USB Device +Host ARMmbed/mbed-os#3626
3628: Fix warnings ARMmbed/mbed-os#3628
3629: STM32: L0 LL layer ARMmbed/mbed-os#3629
3632: IDE Export support for platform VK_RZ_A1H ARMmbed/mbed-os#3632
3642: Missing IRQ pin fix for platform VK_RZ_A1H ARMmbed/mbed-os#3642
3664: Fix ncs36510 sleep definitions ARMmbed/mbed-os#3664
3655: [STM32F4] Modify folder structure ARMmbed/mbed-os#3655
3657: [STM32L4] Modify folder structure ARMmbed/mbed-os#3657
3658: [STM32F3] Modify folder structure ARMmbed/mbed-os#3658
3685: STM32: I2C: reset state machine ARMmbed/mbed-os#3685
3692: uVisor: Standardize available legacy heap and stack ARMmbed/mbed-os#3692
3621: Fix for #2884, LPC824: export to LPCXpresso, target running with wron ARMmbed/mbed-os#3621
3649: [STM32F7] Modify folder structure  ARMmbed/mbed-os#3649
3695: Enforce device_name is valid in targets.json ARMmbed/mbed-os#3695
3723: NCS36510: spi_format function bug fix ARMmbed/mbed-os#3723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants