-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: Fix requirements install #5061
Conversation
Is there any doc reference for this? Is also the fix referenced above needed or this supersedes it? |
So what I can find on the python side: https://www.python.org/dev/peps/pep-0370/ Basically, They added Options are use
Good point, will remove |
fa01cff
to
b2bbaf7
Compare
- pip install --user hypothesis | ||
- pip install --user mock | ||
- pip install --user coverage | ||
- pip install --user coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not we have a requirements-travis.txt or requirements-test.txt file for theses? If not, why don't we install all packages in one pip install command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this list is big enough to need another level of indirection IMO.
I can run these all in one command though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, for some reason combining all of the requirements into one pip install command caused travis to fail. I couldn't figure out why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am right, the error is from six import wraps - ImportError: cannot import name wraps
.
Here I found that Mock requires six version 1.7 or newer.
I think you should add pip install --upgrade six
to upgrade the already installed six to the newest version.
Anyway, I'm being picky, if it's good enough for mbed's maintainers, let's merge as it is :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, then why would pip work in this configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum yeah, you are right ... no idea ¯(°_o)/¯
de8c730
to
c10adfa
Compare
pip requires --user flag when installing executables outside of sudo context
c10adfa
to
94c972e
Compare
@0xc0170, this is probably ready, won't need morph test either |
2X travis builds. This must be extra safe! |
Needs --user flag for reasons, see ARMmbed/mbed-os#5061 superseeds #60 cc @deepikabhavnani
pip requires --user flag when installing executables outside of sudo context
see #5055
cc @0xc0170, @theotherjimmy