Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis: Fix requirements install #5061

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Travis: Fix requirements install #5061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
python:
- "2.7"
group: deprecated-2017Q3
script:
- mkdir BUILD
# Assert that the Doxygen build produced no warnings.
Expand Down Expand Up @@ -36,10 +35,10 @@ before_install:
- python --version
- doxygen --version
install:
- pip install -r requirements.txt
- pip install pytest
- pip install pylint
- pip install hypothesis
- pip install mock
- pip install coverage
- pip install coveralls
- pip install --user -r requirements.txt
- pip install --user pytest
- pip install --user pylint
- pip install --user hypothesis
- pip install --user mock
- pip install --user coverage
- pip install --user coveralls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we have a requirements-travis.txt or requirements-test.txt file for theses? If not, why don't we install all packages in one pip install command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this list is big enough to need another level of indirection IMO.

I can run these all in one command though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, for some reason combining all of the requirements into one pip install command caused travis to fail. I couldn't figure out why.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am right, the error is from six import wraps - ImportError: cannot import name wraps.
Here I found that Mock requires six version 1.7 or newer.
I think you should add pip install --upgrade six to upgrade the already installed six to the newest version.

Anyway, I'm being picky, if it's good enough for mbed's maintainers, let's merge as it is :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, then why would pip work in this configuration?

Copy link
Contributor

@Nodraak Nodraak Sep 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum yeah, you are right ... no idea ¯(°_o)/¯