Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration - Port some fixes from main to RB-2.0 - Adsk Contrib #1745

Closed
wants to merge 5 commits into from
Closed

Integration - Port some fixes from main to RB-2.0 - Adsk Contrib #1745

wants to merge 5 commits into from

Commits on Jan 5, 2023

  1. Changing version release type for 2.0.5 official release. 

    Signed-off-by: Cédrik Fuoco <[email protected]>
    @cedrik-fuoco-adsk
    cedrik-fuoco-adsk committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    3eb0c17 View commit details
    Browse the repository at this point in the history

  2. Fix atan2 argument order for HLSL (#1712) 

    Signed-off-by: Doug Walker <[email protected]>

Signed-off-by: Doug Walker <[email protected]>
(cherry picked from commit 8a93946)
    @doug-walker @cedrik-fuoco-adsk
    doug-walker authored and cedrik-fuoco-adsk committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    81ab77a View commit details
    Browse the repository at this point in the history

  3. replace texture2D function with texture for GLSL 1.3 (#1723) 

    Signed-off-by: Bart Styczen <[email protected]>

Signed-off-by: Bart Styczen <[email protected]>
Co-authored-by: Doug Walker <[email protected]>
(cherry picked from commit d5cedbf)
    @bartstyczen @cedrik-fuoco-adsk
    bartstyczen authored and cedrik-fuoco-adsk committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    2e544e2 View commit details
    Browse the repository at this point in the history

  4. Adsk contrib - Processor cache does not detect changes in cccid (#1726) 

    * For Looks that has a FileTransform and for Colorspace with FileTransfrom, add the CCCID to the processor's cache key for that transform.

Signed-off-by: Cédrik Fuoco <[email protected]>

* Removing the workaround in the related unit tests and fixing the issue by adding the environment variable to the context using setStringVar. The processor's cache key is using the context cache ID which has all the context variables taken into account.

Signed-off-by: Cédrik Fuoco <[email protected]>

* Now using addStringVars and creating a new context instead of reusing the one used for the filename.

Signed-off-by: Cédrik Fuoco <[email protected]>

* Adding cccid to the context when there are no context variable.

Signed-off-by: Cédrik Fuoco <[email protected]>

* Adding a few unit tests to test that the processor is different when changing the FileTransform's CCCID.

Signed-off-by: Cédrik Fuoco <[email protected]>

* Using setStringVar to set CCNUM context variable in unit test.

Signed-off-by: Cédrik Fuoco <[email protected]>

* Adding a test in FileTransform to test CollectContextVariables directly.

Signed-off-by: Cédrik Fuoco <[email protected]>

* Minor tweaks for the unit test

Signed-off-by: Cédrik Fuoco <[email protected]>

Signed-off-by: Cédrik Fuoco <[email protected]>
Co-authored-by: Doug Walker <[email protected]>
(cherry picked from commit 4fa7750)
    @cedrik-fuoco-adsk
    cedrik-fuoco-adsk committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    3d5c944 View commit details
    Browse the repository at this point in the history

  5. Fix inverse Lut1D optimization bug (#1743) 

    Signed-off-by: Doug Walker <[email protected]>

Signed-off-by: Doug Walker <[email protected]>
(cherry picked from commit 5152635)
    @doug-walker @cedrik-fuoco-adsk
    doug-walker authored and cedrik-fuoco-adsk committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    fdfd8a8 View commit details
    Browse the repository at this point in the history