Initial work to start switch to core use in C++ side #1719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional API for querying information from the context for integration into the C++ code base. These should be reviewed prior to final release whether they need to persist or are only temporary Signed-off-by: Kimball Thurston <[email protected]>
These are not final, but should represent concepts we will use in new world of using the core to replace the internals of the C++ Signed-off-by: Kimball Thurston <[email protected]>
This is not complete (some of the dependencies are circular, so depends on other later conversions to finish), so represents a WIP state Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Not sure when that got added to the C++ library, but wasn't in the core Signed-off-by: Kimball Thurston <[email protected]>
Add additional constructor to opaque attribute to enable this. Registered custom attributes still TODO Signed-off-by: Kimball Thurston <[email protected]>
Long name attribute flags was not being set correctly and the rules around when there is a mismatch between the bit flags in the header and the type attribute were not being correctly handled Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
meshula
reviewed
Apr 17, 2024
| @@ -742,8 +742,8 @@ exr_read_scanline_chunk_info ( | |||
|
|
|||
| if (!cinfo) return ctxt->standard_error (ctxt, EXR_ERR_INVALID_ARGUMENT); | |||
|
|
|||
| if (part->storage_mode == EXR_STORAGE_TILED || | |||
There was a problem hiding this comment.
yikes! I think this a bug fix to fastrack to main
meshula
reviewed
Apr 17, 2024
| @@ -1002,8 +1002,8 @@ exr_read_tile_chunk_info ( | |||
|
|
|||
| if (!cinfo) return ctxt->standard_error (ctxt, EXR_ERR_INVALID_ARGUMENT); | |||
|
|
|||
| if (part->storage_mode == EXR_STORAGE_SCANLINE || | |||
There was a problem hiding this comment.
yikes! I think this a bug fix to fastrack to main
| @@ -1676,8 +1683,13 @@ check_populate_version ( | |||
|
|
|||
| attrsz = (int32_t) one_to_native32 ((uint32_t) attrsz); | |||
| if (attrsz != 1) | |||
| return ctxt->print_error ( | |||
| @@ -144,6 +145,10 @@ InputFile::InputFile (InputPartData* part) | |||
| initialize (); | |||
| } | |||
|
|
|||
| InputFile::~InputFile () | |||
There was a problem hiding this comment.
are you gonna put something in here? this might be just an =default in the header?
There was a problem hiding this comment.
oh, probably, I always get weird with virtual tables and force them to be in a specific translation unit. However, as soon as I remove the generic input file base class, will remove the vtable entirely, it is not needed / helpful (and will switch to rule of 0)
|
yes, will talk around my plan at the TSC meeting tomorrow |
Signed-off-by: Kimball Thurston <[email protected]>
|
splitting apart and moving to new branch, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit will hopefully break down what are going to be some large changes. This represents what will be a longer chain of conversion of the C++ library to use the core library internally to gain the benefits present there.
Website preview: https://openexr--1719.org.readthedocs.build/en/1719/