Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial work to start switch to core use in C++ side #1719

Closed
wants to merge 12 commits into from
Closed

Initial work to start switch to core use in C++ side #1719

wants to merge 12 commits into from

Commits on Apr 16, 2024

  1. Add api for C++ integration 

    Add additional API for querying information from the context for
integration into the C++ code base. These should be reviewed prior to
final release whether they need to persist or are only temporary

Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    6578b5c View commit details
    Browse the repository at this point in the history

  2. Add initial context objects 

    These are not final, but should represent concepts we will use in new
world of using the core to replace the internals of the C++

Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b830434 View commit details
    Browse the repository at this point in the history

  3. Initial conversion of input file to use core 

    This is not complete (some of the dependencies are circular, so depends
on other later conversions to finish), so represents a WIP state

Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e2d501e View commit details
    Browse the repository at this point in the history

  4. Add new files to fix bazel build check 

    Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f185741 View commit details
    Browse the repository at this point in the history

  5. Add missing deep image state attribute 

    Not sure when that got added to the C++ library, but wasn't in the core

Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    bc99986 View commit details
    Browse the repository at this point in the history

  6. Complete conversion of header attributes to header class 

    Add additional constructor to opaque attribute to enable this.
Registered custom attributes still TODO

Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    882dba2 View commit details
    Browse the repository at this point in the history

  7. Fix flag handling and storage type validation to match 

    Long name attribute flags was not being set correctly and the rules
around when there is a mismatch between the bit flags in the header and
the type attribute were not being correctly handled

Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ac0882f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Add unknown storage mode for future proofing, fix logic 

    Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    71bac2a View commit details
    Browse the repository at this point in the history

  2. Properly bridge to multipart file for now 

    Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c875e98 View commit details
    Browse the repository at this point in the history

  3. Better handle streams and attempts to read past end 

    Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    66aceb0 View commit details
    Browse the repository at this point in the history

  4. handle custom attributes 

    Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2297c10 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Remove unused header, fix attribute spec order to work with clang 

    Signed-off-by: Kimball Thurston <[email protected]>
    @kdt3rd
    kdt3rd committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    43155c0 View commit details
    Browse the repository at this point in the history