Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rez-pip doesn't include arch/platform in variant for packages with platform-specific generated scripts #1286

Closed
bpabel opened this issue Apr 16, 2022 · 2 comments · Fixed by #1287
Labels
bug rez-pip ingesting py pkgs into rez (pip, wheels, etc)

Comments

@bpabel
Copy link
Contributor

bpabel commented Apr 16, 2022

rez-pip currently only includes platform and arch in the variant when generating a rez package for python packages that aren't pure python. However, pure python packages that define entry points scripts (console_scripts or gui_scripts) will generate platform-specific executables, and require the platform and arch tags, so that installations from different platforms can be installed to separate variants, each with their own set of generated platform-specific executables.

Environment

  • OS - all os's
  • Rez version - "2.107.0")
  • Rez python version - Python 3.7.7

To Reproduce

  1. rez-pip a pure python package with console scripts (e.g. rez-pip -i flit)

Expected behavior
The generated package.py variant includes the platform and arch packages it was generated from.

Actual behavior
The generated package.py variant does not include the platform and arch packages it was generated from (only the python version).

@bpabel
Copy link
Contributor Author

bpabel commented Jun 24, 2022

Just wanted to follow up on how to push this along. It's a critical show-stopping bug for rez-pip. There are some automated failures in the CI that look permission related but I'm not sure.

@nerdvegas
Copy link
Contributor

nerdvegas commented Jun 25, 2022 via email

@JeanChristopheMorinPerso JeanChristopheMorinPerso added the rez-pip ingesting py pkgs into rez (pip, wheels, etc) label Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rez-pip ingesting py pkgs into rez (pip, wheels, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants