fix: add platform/arch to variant for rez-pip packages with entry point scripts #1287
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
I looked at the build failures and I'm not too sure what's going on. And our builds are being massively queued right now, which makes debugging quite difficult. Also, you will have to sign off your commits. See https://github.com/AcademySoftwareFoundation/rez/pull/1287/checks?check_run_id=6716785034. |
bpabel
force-pushed
the
fix/1286-rez-pip-variant
branch
2 times, most recently
from
f087b1a
to
727a1d0
Compare
|
Hey @bpabel , can you rebase your branch with master please? That should fix the windows build issues. Thanks! |
|
Actually, wait a little bit, we have another failure on master. |
|
Alright, you can rebase now. The issue has been fixed and the workflow should work. |
…nt scripts Signed-off-by: Brendan Abel <[email protected]>
Signed-off-by: Brendan Abel <[email protected]>
Signed-off-by: Brendan Abel <[email protected]>
bpabel
force-pushed
the
fix/1286-rez-pip-variant
branch
from
727a1d0
to
538ba0e
Compare
|
@JeanChristopheMorinPerso Cool, thanks. Rebased and updated from your notes. Looks like builds are succeeding now. |
There was a problem hiding this comment.
Looks good to me. @instinct-vfx any opinion on this before we merge this PR?
|
I did not have the chance to actually test myself but it looks good to me and is also an important fix (specifically on windows). At some time in the future i would like to revisit rez-pip, move to a more sensible approach to the file mapping and also add less specific variants for pure python packages without entrypoints. Good one! |
Fixes #1286