Branches - Farah #36
Open
Branches - Farah #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Feb 23, 2020
There was a problem hiding this comment.
Nice work, you hit all the learning goals here. Well done. Take a look at my comments and let me know if you have questions. The methods you have written all work and you've demonstrated an understanding of how to implement a Linked List. Nice work implementing has_cycle.
| @@ -19,54 +19,142 @@ def initialize | |||
| # method to add a new node with the specific data value in the linked list | |||
| # insert the new node at the beginning of the linked list | |||
| def add_first(value) | |||
| new_node.next = @head | ||
| @head = new_node | ||
|
|
||
| # @head = Node.new(value, @head) | ||
| end | ||
|
|
||
| # method to find if the linked list contains a node with specified value | ||
| # returns true if found, false otherwise | ||
| def search(value) |
| return nil if @head.nil? | ||
|
|
||
| current = @head | ||
| max = 0 |
There was a problem hiding this comment.
Consider if the list held negative numbers.
Suggested change
| max = 0 | |
| max = @current.data |
| current = current.next | ||
| end | ||
|
|
||
| return max | ||
| end | ||
|
|
||
| # method to return the min value in the linked list | ||
| # returns the data value and not the node | ||
| def find_min |
| end | ||
|
|
||
|
|
||
| # method that returns the length of the singly linked list | ||
| def length | ||
| raise NotImplementedError | ||
| def length |
| n_ahead = n_ahead.next | ||
| end | ||
|
|
||
| return current.data | ||
| end | ||
|
|
||
| # checks if the linked list has a cycle. A cycle exists if any node in the | ||
| # linked list links to a node already visited. | ||
| # returns true if a cycle is found, false otherwise. | ||
| def has_cycle |
| return true | ||
| end | ||
| end | ||
| return false | ||
| end | ||
|
|
||
|
|
||
| # Additional Exercises | ||
| # returns the value in the first node | ||
| # returns nil if the list is empty | ||
| def get_first |
| # raise NotImplementedError | ||
| return nil if @head == nil | ||
|
|
||
| return @head.data | ||
| end | ||
|
|
||
| # method that inserts a given value as a new last node in the linked list | ||
| def add_last(value) |
| current = current.next | ||
| end | ||
|
|
||
| current.next = new_node | ||
| end | ||
|
|
||
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| def get_last |
| current = current.next | ||
| end | ||
|
|
||
| return current.data | ||
| end | ||
|
|
||
| # method to insert a new node with specific data value, assuming the linked | ||
| # list is sorted in ascending order | ||
| def insert_ascending(value) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.