Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Farah #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
187 changes: 171 additions & 16 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,54 +19,142 @@ def initialize
# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
def add_first(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
new_node = Node.new(value)
new_node.next = @head
@head = new_node

# @head = Node.new(value, @head)
end

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
def search(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
current = @head
until current.nil?
return true if current.data == value

current = current.next
end

return false
end

# method to return the max value in the linked list
# returns the data value and not the node
def find_max
raise NotImplementedError
return nil if @head.nil?

current = @head
max = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider if the list held negative numbers.

Suggested change
max = 0
max = @current.data

until current.nil?
if current.data > max
max = current.data
end
current = current.next
end

return max
end

# method to return the min value in the linked list
# returns the data value and not the node
def find_min

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
return nil if @head.nil?

current = @head
min = current.data

until current.nil?
if current.data < min
min = current.data
end
current = current.next
end

return min
end


# method that returns the length of the singly linked list
def length
raise NotImplementedError
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head
counter = 0
until current.nil?
counter += 1
current = current.next
end

return counter
end

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns nil if there are fewer nodes in the linked list than the index value
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
# raise NotImplementedError
length = self.length
if index > length
return nil
end

current = @head

index.times do
current = current.next
end

return current.data
end

# method to print all the values in the linked list
def visit
raise NotImplementedError
length = self.length
values = []

current = @head
length.time do
values << current.data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
values << current.data
puts current.data

current = current.next
end
end

# method to delete the first node found with specified value
def delete(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
current = @head
previous = nil

return nil if current.nil?

until current.data == value
return nil if current.nil?
previous = current
current = current.next
end

if previous == nil
@head = current.next
else
previous.next = current.next
end
end

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
def reverse

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
return if @head.nil?

current = @head
previous = nil

until current.next.nil?
temp = current.next
current.next = previous
previous = current
current = temp
end

current.next = previous
@head = current
end


Expand All @@ -79,39 +167,106 @@ def find_middle_value
# find the nth node from the end and return its value
# assume indexing starts at 0 while counting to n
def find_nth_from_end(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
return nil if @head.nil?

current = @head
n_ahead = @head

n.times do
return if n_ahead.next.nil?
n_ahead = n_ahead.next
end

until n_ahead.next.nil?
current = current.next
n_ahead = n_ahead.next
end

return current.data
end

# checks if the linked list has a cycle. A cycle exists if any node in the
# linked list links to a node already visited.
# returns true if a cycle is found, false otherwise.
def has_cycle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
return nil if @head.nil?

fast = @head
slow = @head

until fast.nil? || fast.next.nil?
fast = fast.next.next
slow = slow.next
if fast == slow
return true
end
end
return false
end


# Additional Exercises
# returns the value in the first node
# returns nil if the list is empty
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
# raise NotImplementedError
return nil if @head == nil

return @head.data
end

# method that inserts a given value as a new last node in the linked list
def add_last(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
# raise NotImplementedError
# length = self.length
new_node = Node.new(value)

current = @head
if current.nil?
return @head = new_node
end

until current.next.nil?
current = current.next
end

current.next = new_node
end

# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
def get_last

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
# raise NotImplementedError
# length = self.length

return nil if @head.nil?

current = @head
until current.next == nil
current = current.next
end

return current.data
end

# method to insert a new node with specific data value, assuming the linked
# list is sorted in ascending order
def insert_ascending(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
return nil if @head.nil?

current = @head

until current.nil?
if value > current.data && value <= current.next.data
new_node = Node.new(value, current.next)
current.next = new_node
return
else
current = current.next
end
end

return current = Node.new(value)
end

# Helper method for tests
Expand Down