Branches - Macaria #35

mdove92 · 2019-12-09T08:03:34Z

Linked List Comprehension Questions

Question	Response
1. What advantages does a LinkedList have over an Array?	A linked list is more memory efficient because you only need to allocate as much memory as there are elements, instead of allocating a whole block initially.
2. When is an Array more advantageous?	It is quicker to insert a value into the middle of an array than a linked list.

CheezItMan · 2019-12-18T06:15:50Z

Just in response to your comprehension questions.

Yes
No, both are O(n) to insert into the middle. However to find an element in a sorted array is much faster and to get an element from a specific index it's also faster.

CheezItMan

You definitely have a feel for linked lists, but you have a few bugs here. Take a look at my comments and let me know if you have questions.

CheezItMan · 2019-12-18T06:16:10Z

lib/linked_list.rb

@@ -10,36 +10,71 @@ def initialize
  # Time complexity - ?
  # Space complexity - ?
  def add_first(data)


CheezItMan · 2019-12-18T06:16:19Z

lib/linked_list.rb

@@ -10,36 +10,71 @@ def initialize
  # Time complexity - ?
  # Space complexity - ?
  def add_first(data)
-
+    @head = Node.new(data, @head)
  end

  # Time complexity - ?
  # Space complexity - ?
  def get_first


CheezItMan · 2019-12-18T06:16:28Z

lib/linked_list.rb

+      return nil
+    else
+      return @head.data
+    end
  end

  # Time complexity - ?
  # Space complexity - ?
  def length


CheezItMan · 2019-12-18T06:17:09Z

lib/linked_list.rb

+      count += 1
+      temp = temp.next
+    end
+    return count
  end

  # Time complexity - ?
  # Space complexity - ?
  def add_last(data)


👍
This works, but it's a little overly complex. Can you see a way to simplify it?

CheezItMan · 2019-12-18T06:17:40Z

lib/linked_list.rb

  end

  # Time complexity - ?
  # Space complexity - ?
  def get_last
+    temp = @head


What if head is nil?

Suggested change

temp = @head

return nil if @head.nil?

temp = @head

CheezItMan · 2019-12-18T06:18:08Z

lib/linked_list.rb

+    while temp != nil && temp.next != nil
+      temp = temp.next
+    end
+    return temp.data
  end

  # Time complexity - ?
  # Space complexity - ?
  def get_at_index(index)


What about if the index is greater than the length of the list?

Finished linked list methods

75973d5

mdove92 changed the title ~~Finished linked list methods~~ Branches - Macaria Dec 9, 2019

CheezItMan reviewed Dec 18, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branches - Macaria #35

Branches - Macaria #35

mdove92 commented Dec 9, 2019

CheezItMan commented Dec 18, 2019

CheezItMan left a comment

CheezItMan Dec 18, 2019

CheezItMan Dec 18, 2019

CheezItMan Dec 18, 2019

CheezItMan Dec 18, 2019

CheezItMan Dec 18, 2019

CheezItMan Dec 18, 2019

Branches - Macaria #35

Are you sure you want to change the base?

Branches - Macaria #35

Conversation

mdove92 commented Dec 9, 2019

Linked List Comprehension Questions

CheezItMan commented Dec 18, 2019

CheezItMan left a comment

Choose a reason for hiding this comment

CheezItMan Dec 18, 2019

Choose a reason for hiding this comment

CheezItMan Dec 18, 2019

Choose a reason for hiding this comment

CheezItMan Dec 18, 2019

Choose a reason for hiding this comment

CheezItMan Dec 18, 2019

Choose a reason for hiding this comment

CheezItMan Dec 18, 2019

Choose a reason for hiding this comment

CheezItMan Dec 18, 2019

Choose a reason for hiding this comment