Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Macaria #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 40 additions & 5 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require_relative 'node'
require_relative "node"

class LinkedList
attr_reader :head
Expand All @@ -10,36 +10,71 @@ def initialize
# Time complexity - ?
# Space complexity - ?
def add_first(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


@head = Node.new(data, @head)
end

# Time complexity - ?
# Space complexity - ?
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


if @head.nil?
return nil
else
return @head.data
end
end

# Time complexity - ?
# Space complexity - ?
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0
count = 0
temp = @head
while temp != nil
count += 1
temp = temp.next
end
return count
end

# Time complexity - ?
# Space complexity - ?
def add_last(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
This works, but it's a little overly complex. Can you see a way to simplify it?

temp = @head
while temp != nil && temp.next != nil
temp = temp.next
end
last_node = Node.new(data)

if (temp != nil)
temp.next = last_node
else
@head = last_node
end
end

# Time complexity - ?
# Space complexity - ?
def get_last
temp = @head

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
temp = @head
return nil if @head.nil?
temp = @head


while temp != nil && temp.next != nil
temp = temp.next
end
return temp.data
end

# Time complexity - ?
# Space complexity - ?
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the index is greater than the length of the list?


temp = @head
count = 0
while count < index && temp != nil
temp = temp.next
count += 1
end
if (count == index)
return temp.data
else
return nil
end
end
end
38 changes: 17 additions & 21 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
require 'minitest/autorun'
require 'minitest/reporters'
require "minitest/autorun"
require "minitest/reporters"
require "minitest/skip_dsl"

require_relative '../lib/linked_list'

require_relative "../lib/linked_list"

Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

Expand All @@ -13,24 +12,24 @@
@list = LinkedList.new
end

describe 'initialize' do
it 'can be created' do
describe "initialize" do
it "can be created" do

# Assert
expect(@list).must_be_kind_of LinkedList
end
end

xdescribe 'add_first & get_first' do
it 'can add values to an empty list' do
describe "add_first & get_first" do
it "can add values to an empty list" do
# Act
@list.add_first(3)
@list.add_first(3)

# Assert
expect(@list.get_first).must_equal 3
# Assert
expect(@list.get_first).must_equal 3
end

it 'will put the last added item to the front of the list' do
it "will put the last added item to the front of the list" do
# Act
@list.add_first(1)
@list.add_first(2)
Expand All @@ -45,13 +44,12 @@
expect(@list.get_first).must_equal 3
end

it 'will return `nil` for `getFirst` if the list is empty' do

it "will return `nil` for `getFirst` if the list is empty" do
expect(@list.get_first).must_be_nil
end
end

xdescribe "length" do
describe "length" do
it "will return 0 for an empty list" do
expect(@list.length).must_equal 0
end
Expand All @@ -66,7 +64,7 @@
end
end

xdescribe "addLast & getLast" do
describe "addLast & getLast" do
it "will add to the front if the list is empty" do
@list.add_last(1)
expect(@list.get_first).must_equal 1
Expand All @@ -86,17 +84,15 @@
expect(@list.get_first).must_equal 2
expect(@list.get_last).must_equal 4
expect(@list.length).must_equal 3

end

end

xdescribe 'get_at_index' do
it 'returns nil if the index is outside the bounds of the list' do
describe "get_at_index" do
it "returns nil if the index is outside the bounds of the list" do
expect(@list.get_at_index(3)).must_be_nil
end

it 'can retrieve an item at an index in the list' do
it "can retrieve an item at an index in the list" do
@list.add_first(1)
@list.add_first(2)
@list.add_first(3)
Expand Down