Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new scriptlet — 'trusted-set-attr' #281

Closed
slavaleleka opened this issue Jan 13, 2023 · 1 comment
Closed

Add new scriptlet — 'trusted-set-attr' #281

slavaleleka opened this issue Jan 13, 2023 · 1 comment

Comments

@slavaleleka
Copy link
Contributor

Original issue: #106

@slavaleleka slavaleleka changed the title Add new scriptlet — 'trusted-set-element-attribute' Add new scriptlet — 'trusted-set-attr' Jan 20, 2023
@ghost
Copy link

ghost commented Jan 14, 2024

I don't want to be that person but is Adguard going to implement this?
While set-attr I see it mostly about 'fixing the web' rather than adblocking it would be great to have it available in Adguard and be able to set any value we want.

For example, many input elements don't have the autocomplete="off" which means you will get suggestions in other sites or even synchronized across devices, only because the input share the same 'name', this means Inputs are security and privacy nightmare in some cases, doesn't necessarily means you want to turn them off completely, but don't let some websites 'record' autofill data like that.
So if Adguard allowed to fix that issue some web developers don't care about, even if it is as simple as adding that attribute, would be great.

Also this could easily tweak links to be opened in self or new tab, rather than be dependent on what the web developer implemented.

I know Adguard will care about security risks, but freedom of internet is also important, and being able to fix bad web developer decisions is always a plus, even if that requires to fix the web for and by ourself, it would be great.

The scriptlet is already there, and implement it 'trusted' would be great, rather than expanding set-attr trusted values, to every possibility. Looking at the original issue, it's been more than 3 years since it was mentioned and this issue is a year old already.

So I hope this will get implemented soon, eventually, someday, some time in my lifetime.

adguard pushed a commit that referenced this issue Feb 8, 2024
Squashed commit of the following:

commit 3eadd53
Author: Slava Leleka <[email protected]>
Date:   Thu Feb 8 18:58:54 2024 +0200

    disable jsdoc/require-returns eslint rule

commit 364d9ee
Author: Slava Leleka <[email protected]>
Date:   Thu Feb 8 18:58:33 2024 +0200

    fix defaultAttributeSetter() doc

commit 0899055
Merge: 738d900 14ceeaa
Author: Slava Leleka <[email protected]>
Date:   Thu Feb 8 16:45:01 2024 +0200

    Merge branch 'master' into feature/AG-18849

commit 738d900
Merge: 8f4bc9d 7446aa3
Author: Slava Leleka <[email protected]>
Date:   Thu Feb 8 15:44:00 2024 +0200

    Merge branch 'master' into feature/AG-18849

commit 8f4bc9d
Author: Slava Leleka <[email protected]>
Date:   Wed Feb 7 21:44:03 2024 +0200

    update changelog

commit 4fbdfc2
Author: Slava Leleka <[email protected]>
Date:   Wed Feb 7 21:39:33 2024 +0200

    improve logging for invalid attr value

commit 6d12f81
Author: Slava Leleka <[email protected]>
Date:   Wed Feb 7 21:38:01 2024 +0200

    avoid negative variable names

commit 78b3340
Author: Slava Leleka <[email protected]>
Date:   Wed Feb 7 21:26:32 2024 +0200

    add logging if no attr found

commit d5c569c
Author: Slava Leleka <[email protected]>
Date:   Wed Feb 7 21:24:05 2024 +0200

    fix test

commit d232808
Merge: 3d24a71 eb007ec
Author: Stanislav Atroschenko <[email protected]>
Date:   Mon Feb 5 15:51:52 2024 +0300

    Merge branch 'master' into feature/AG-18849

commit 3d24a71
Author: Stanislav Atroschenko <[email protected]>
Date:   Fri Feb 2 23:30:36 2024 +0300

    redo trusted-set-attr tests

commit bf797df
Author: Stanislav Atroschenko <[email protected]>
Date:   Fri Feb 2 23:12:06 2024 +0300

    improve set-attr tests

commit 24bbfb1
Author: Stanislav Atroschenko <[email protected]>
Date:   Fri Feb 2 21:11:10 2024 +0300

    add testcase for a special param value of set-attr

commit 88c365f
Author: Stanislav Atroschenko <[email protected]>
Date:   Fri Feb 2 20:38:45 2024 +0300

    add special [attribute-name] param value

commit 8e47996
Author: Stanislav Atroschenko <[email protected]>
Date:   Fri Feb 2 16:43:51 2024 +0300

    fix docs for both set-attr scriptlets

commit d607ad5
Author: Stanislav Atroschenko <[email protected]>
Date:   Wed Jan 31 18:17:17 2024 +0300

    improve and fix docs

commit 3cee17e
Author: Slava Leleka <[email protected]>
Date:   Wed Jan 31 18:12:20 2024 +0300

    src/scriptlets/trusted-set-attr.js edited online with Bitbucket

commit 1d89af9
Author: Stanislav Atroschenko <[email protected]>
Date:   Wed Jan 31 15:59:17 2024 +0300

    fix if condition

commit 0f49db5
Author: Stanislav Atroschenko <[email protected]>
Date:   Wed Jan 31 15:57:21 2024 +0300

    update changelog

commit 518c485
Author: Stanislav Atroschenko <[email protected]>
Date:   Wed Jan 31 15:49:34 2024 +0300

    add testcase

... and 3 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants