add /getCostEstimate Resource model #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cangelis
requested review from
Aleffio,
AlexandrosMor,
cyattilakiss,
msilvagarcia and
rikterbeek
as code owners
|
Thanks for submitting this to us! Implementation looks very good, indeed. Would you be able to provide some unit tests as well? Cheers! |
acampos1916
approved these changes
Jan 27, 2020
AlexandrosMor
approved these changes
Jan 29, 2020
|
Hello @cangelis, I see that there are some conflicts. Is it possible for you to resolve them? When it is done it will possible for us to merge it. Kind regards, |
cyattilakiss
approved these changes
Feb 3, 2020
AlexandrosMor
approved these changes
Feb 4, 2020
msilvagarcia
approved these changes
Feb 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing
/getCostEstimateendpoint resource model