[PW-2385] Add check notification event code supports hmac. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrosMor
requested review from
acampos1916,
Aleffio,
cyattilakiss,
msilvagarcia and
rikterbeek
as code owners
AlexandrosMor
changed the title
|
@AlexandrosMor Please see the code smell from sonar cloud! |
Aleffio
reviewed
May 22, 2020
| @@ -127,4 +127,22 @@ public function testHmacSignatureEscaping() | |||
| $this->fail('Unexpected exception'); | |||
| } | |||
| } | |||
|
|
|||
| public function testisHmacSupportedEventCode() | |||
There was a problem hiding this comment.
very minor
Suggested change
| public function testisHmacSupportedEventCode() | |
| public function testIsHmacSupportedEventCode() |
acampos1916
previously approved these changes
May 22, 2020
rikterbeek
reviewed
May 22, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
msilvagarcia
approved these changes
May 22, 2020
acampos1916
approved these changes
May 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the check isHmacSupportedEventCode to the library. This check returns true if the notification event code supports hmac calculation.
Tested scenarios
Add Unit test to test an existing event code in the list