Release 6.3.0 #207
Merged
Release 6.3.0 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependency phpunit/phpunit to v9.0.2
Create a security policy as per GitHub recommendation
* [PW-2387]: IP address validation util class * [PW-2387]: Removing reverse-resolve function * [PW-2387]: Fixes
Renovate bot missed this on pull request #180. Manually updated it for now. Rewrote several tests to make it work.
Create a GitHub Actions Workflow that validates the code on pushes and pull requests, while also sending relevant data to SonarCloud.
PHPUnit generates the Clover coverage files with absolute file paths, and I couldn't find a way to change that. So, instead, I set up a step in the Continuous Integration workflow to clean up the report files after it runs.
* Add a check method for hmac supported notification event codes * Add unit test for isHmacSupportedEventCode * Fix test * Fix eventcode array * Add error handling in testIsHmacSupportedEventCode * Fix code smell * EVENTCODE to EVENT_CODE
This runs the integration tests as GitHub Actions on every push and every pull request.
cyattilakiss
requested review from
AlexandrosMor,
msilvagarcia and
rikterbeek
as code owners
acampos1916
previously approved these changes
Jun 25, 2020
AlexandrosMor
previously approved these changes
Jun 26, 2020
msilvagarcia
previously approved these changes
Jun 26, 2020
cyattilakiss
dismissed stale reviews from msilvagarcia, AlexandrosMor, and acampos1916
via
462aa2a
|
SonarCloud Quality Gate failed.
|
msilvagarcia
approved these changes
Jun 26, 2020
acampos1916
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#197 [PW-2385] Add check notification event code supports hmac.
#198 [PW-2409] Add integration tests to continuous integration
Tested scenarios
Fixed issue: