Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITT-413] Data Protection API #480

Merged
merged 7 commits into from
Apr 7, 2023
Merged

[ITT-413] Data Protection API #480

merged 7 commits into from
Apr 7, 2023

Conversation

michaelpaul
Copy link
Contributor

Description

Add support for the Data Protection API.

Tested scenarios

  • unit tests

AlexandrosMor
AlexandrosMor previously approved these changes Apr 6, 2023
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some linting issues in model. maybe due to template changes?

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@jillingk jillingk enabled auto-merge (squash) April 7, 2023 09:04
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@michaelpaul
Copy link
Contributor Author

Some linting issues in model. maybe due to template changes?

Fixed in d71d50d

@jillingk jillingk changed the title ITT-413: Data Protection API [ITT-413] Data Protection API Apr 7, 2023
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approved 🚀

@jillingk jillingk merged commit dd4aa2f into develop Apr 7, 2023
jillingk added a commit that referenced this pull request Apr 18, 2023
* [ITT-398] Final Changes to prepare for Model/Service Automation (#457)

* Automate services, Update Client/Service class

* add target folder to gitignore

* missed the CurlClient

* Remove changes from old branch

* ran codesniffer

* moved baseurl creation to service.php class to reduce duplicate code

* forgot the codesniffer..

* Added typing and replaced php8> operator

* minor fixes

* CurlClient method needs to be public

* modified createBaseURL to be more descriptive and readable

* Change layout to be more explicit and add Unit Tests

* codestyle

* change name of single services

* fix unused var in test

* fix codestatic errors

* Match regular expression..

* TIL that const don't need $

* codestyling

* pull new templates and generate Bcl

* added tests and a class to catch the service url creation

* Moved query param construct to Service class and create file to test the url

* write better mock client for url checker

* refactored to prevent extending the interface and reusing the requestHttp method

* ran codebeautifier

* add type in queryparam annotation

* fix codestyle

* remove idempotency part from requestOptions annotation

* Generated Checkout and added unit tests (also some template fixes for oneOf) (#463)

* [ITT-407] Generate Classic Payments (#467)

* Generate Payments and write tests

* Added modifications tests

* add payments to sonar exclusion

* remove banner

* regenerated

* remove long description in services

* [ITT-405] Model Based Management Endpoints (#468)

* new models/CI

* generate management

* UT and codesniffer

* merge main and generate again

* recover sonar.properties file

* remove long description from service

* [ITT-411] POSTerminalManagement endpoints (#477)

* add POSTerminal endpoints

* fix

* ITT-413: Data Protection API (#480)

* ITT-413: Data Protection API

* ITT-413: Remove contact info

* ITT-413: Update readme

* ITT-413: Auto format generated files

* ITT-413: Sonar

* [ITT-409] Payouts API (#475)

* Generated Payouts and created UT's

* type on sonar properties

* BalanceControl API (#479)

* hotfix checkout url (#469)

Co-authored-by: Wouter Boereboom <[email protected]>

* [ITT-408] Generate Recurring API (#474)

* generate Recurring and create UT

* linting and sonar exclusion

* remove description in service

* removed asci banner to save trees

* [ITT-412] StoredValue API (#478)

* add StoredValue API

* fix

* [ITT-403] LegalEntityManagement endpoints (#471)

* added tests and minor fixes

* exclude from sonar check

* Manual fix in service

* Regenerated

* exclude autogenerated files from sonar

* remove long description in service

* fix generation bug

* ITT-404 Transfers Endpoints (#472)

* setup files and generate Transfers

* tests and cleanup

* add visibility on test functions

* exclude autogenerated files from sonar

* removed long description and added datetime -> string converter in query param builder

* small fix

* small change to query param sanitation

* fix sonar bugs

* [ITT-410] BinLookup API (#476)

* generated binlookup

* fix

* [ITT-37] Add App info Headers to PHP Lib (#482)

* add headers to repo

* introduce const

* [ITT-450] Add service and model generation pipeline (#483)

* add service and model generation pipeline

* update linter

* Update dependency phpunit/phpunit to v9.6.7 (#459)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Deprecate old services (#492)

* add deprecation tag to old services that have a replacement

* phpcbf

* CurlClient request fix (#464)

* small fix to prevent requests without response to be handled as curlError

* hotfix checkout url

---------

Co-authored-by: Wouter Boereboom <[email protected]>

* Create release.yml (#491)

Co-authored-by: Wouter Boereboom <[email protected]>

* regenerate models/services with the camelCase inner arrayAccess (#486)

* [ITT-477] Adjust README in preparation of release (#485)

* first batch of README changes

* add the basic auth part back (partially)

* small fix

* small comment

* adjust readme and makefile to make inner param names camelCase

* remove lines from other pr

* rename notificationReceiver to webhookReceiver (#484)

* rename notificationReceiver to webhookReceiver

* reduce number of return statements in isAuthenticated function of WebhookReceiver class

---------

Co-authored-by: jillingk <[email protected]>

* Finalising for release (#495)

* Finalising for release

* bumpversion

---------

Co-authored-by: Michael Paul <[email protected]>
Co-authored-by: Wouter Boereboom <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@michaelpaul michaelpaul deleted the ITT-413 branch November 8, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants