[ITT-477] Adjust README in preparation of release #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillingk
requested review from
AlexandrosMor,
acampos1916,
peterojo,
rikterbeek,
Morerice,
michaelpaul,
candemiralp and
RokPopov
as code owners
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
|
Also added a makefile line to revert to camelCase naming for easy arrayAccess. Will create a follow up PR to regenerate and adjust the tests. Regenerated models/services in this pr #486 |
|
Kudos, SonarCloud Quality Gate passed!
|
1 similar comment
|
Kudos, SonarCloud Quality Gate passed!
|
wboereboom
reviewed
Apr 14, 2023
wboereboom
reviewed
Apr 14, 2023
antolo-arch
approved these changes
Apr 14, 2023
jillingk
added
breaking change
wboereboom
approved these changes
Apr 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
jillingk
added a commit
that referenced
this pull request
Apr 18, 2023
* [ITT-398] Final Changes to prepare for Model/Service Automation (#457) * Automate services, Update Client/Service class * add target folder to gitignore * missed the CurlClient * Remove changes from old branch * ran codesniffer * moved baseurl creation to service.php class to reduce duplicate code * forgot the codesniffer.. * Added typing and replaced php8> operator * minor fixes * CurlClient method needs to be public * modified createBaseURL to be more descriptive and readable * Change layout to be more explicit and add Unit Tests * codestyle * change name of single services * fix unused var in test * fix codestatic errors * Match regular expression.. * TIL that const don't need $ * codestyling * pull new templates and generate Bcl * added tests and a class to catch the service url creation * Moved query param construct to Service class and create file to test the url * write better mock client for url checker * refactored to prevent extending the interface and reusing the requestHttp method * ran codebeautifier * add type in queryparam annotation * fix codestyle * remove idempotency part from requestOptions annotation * Generated Checkout and added unit tests (also some template fixes for oneOf) (#463) * [ITT-407] Generate Classic Payments (#467) * Generate Payments and write tests * Added modifications tests * add payments to sonar exclusion * remove banner * regenerated * remove long description in services * [ITT-405] Model Based Management Endpoints (#468) * new models/CI * generate management * UT and codesniffer * merge main and generate again * recover sonar.properties file * remove long description from service * [ITT-411] POSTerminalManagement endpoints (#477) * add POSTerminal endpoints * fix * ITT-413: Data Protection API (#480) * ITT-413: Data Protection API * ITT-413: Remove contact info * ITT-413: Update readme * ITT-413: Auto format generated files * ITT-413: Sonar * [ITT-409] Payouts API (#475) * Generated Payouts and created UT's * type on sonar properties * BalanceControl API (#479) * hotfix checkout url (#469) Co-authored-by: Wouter Boereboom <[email protected]> * [ITT-408] Generate Recurring API (#474) * generate Recurring and create UT * linting and sonar exclusion * remove description in service * removed asci banner to save trees * [ITT-412] StoredValue API (#478) * add StoredValue API * fix * [ITT-403] LegalEntityManagement endpoints (#471) * added tests and minor fixes * exclude from sonar check * Manual fix in service * Regenerated * exclude autogenerated files from sonar * remove long description in service * fix generation bug * ITT-404 Transfers Endpoints (#472) * setup files and generate Transfers * tests and cleanup * add visibility on test functions * exclude autogenerated files from sonar * removed long description and added datetime -> string converter in query param builder * small fix * small change to query param sanitation * fix sonar bugs * [ITT-410] BinLookup API (#476) * generated binlookup * fix * [ITT-37] Add App info Headers to PHP Lib (#482) * add headers to repo * introduce const * [ITT-450] Add service and model generation pipeline (#483) * add service and model generation pipeline * update linter * Update dependency phpunit/phpunit to v9.6.7 (#459) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Deprecate old services (#492) * add deprecation tag to old services that have a replacement * phpcbf * CurlClient request fix (#464) * small fix to prevent requests without response to be handled as curlError * hotfix checkout url --------- Co-authored-by: Wouter Boereboom <[email protected]> * Create release.yml (#491) Co-authored-by: Wouter Boereboom <[email protected]> * regenerate models/services with the camelCase inner arrayAccess (#486) * [ITT-477] Adjust README in preparation of release (#485) * first batch of README changes * add the basic auth part back (partially) * small fix * small comment * adjust readme and makefile to make inner param names camelCase * remove lines from other pr * rename notificationReceiver to webhookReceiver (#484) * rename notificationReceiver to webhookReceiver * reduce number of return statements in isAuthenticated function of WebhookReceiver class --------- Co-authored-by: jillingk <[email protected]> * Finalising for release (#495) * Finalising for release * bumpversion --------- Co-authored-by: Michael Paul <[email protected]> Co-authored-by: Wouter Boereboom <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the README similarly to what we have done in the previous libraries.