Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bancontact - Using 'bcmc' instead of 'scheme' for paymentMethod.type #2286

Merged

Conversation

ribeiroguilherme
Copy link
Contributor

@ribeiroguilherme ribeiroguilherme commented Aug 4, 2023

Summary

  • Bancontact now returns paymentMethod type:bcmc instead of 'scheme'

Tested scenarios

  • Tested on live by PBL

Fixed issue: COWEB-1243

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Size Change: +131 B (0%)

Total Size: 1.07 MB

Filename Size Change
packages/lib/dist/adyen.js 283 kB +34 B (0%)
packages/lib/dist/cjs/index.js 245 kB +38 B (0%)
packages/lib/dist/es.modern/index.js 118 kB +25 B (0%)
packages/lib/dist/es/index.js 138 kB +34 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.41 kB
packages/lib/dist/es.modern/cs-CZ.js 5.79 kB
packages/lib/dist/es.modern/da-DK.js 5.27 kB
packages/lib/dist/es.modern/de-DE.js 5.66 kB
packages/lib/dist/es.modern/el-GR.js 7.29 kB
packages/lib/dist/es.modern/es-ES.js 5.36 kB
packages/lib/dist/es.modern/fi-FI.js 5.35 kB
packages/lib/dist/es.modern/fr-FR.js 5.47 kB
packages/lib/dist/es.modern/hr-HR.js 5.49 kB
packages/lib/dist/es.modern/hu-HU.js 5.78 kB
packages/lib/dist/es.modern/it-IT.js 5.34 kB
packages/lib/dist/es.modern/ja-JP.js 6.18 kB
packages/lib/dist/es.modern/ko-KR.js 5.78 kB
packages/lib/dist/es.modern/nl-NL.js 5.37 kB
packages/lib/dist/es.modern/no-NO.js 5.25 kB
packages/lib/dist/es.modern/pl-PL.js 5.76 kB
packages/lib/dist/es.modern/pt-BR.js 5.32 kB
packages/lib/dist/es.modern/pt-PT.js 5.45 kB
packages/lib/dist/es.modern/ro-RO.js 5.58 kB
packages/lib/dist/es.modern/ru-RU.js 6.76 kB
packages/lib/dist/es.modern/sk-SK.js 5.85 kB
packages/lib/dist/es.modern/sl-SI.js 5.43 kB
packages/lib/dist/es.modern/sv-SE.js 5.23 kB
packages/lib/dist/es.modern/zh-CN.js 5.62 kB
packages/lib/dist/es.modern/zh-TW.js 5.74 kB
packages/lib/dist/es/ar.js 6.41 kB
packages/lib/dist/es/cs-CZ.js 5.79 kB
packages/lib/dist/es/da-DK.js 5.27 kB
packages/lib/dist/es/de-DE.js 5.66 kB
packages/lib/dist/es/el-GR.js 7.29 kB
packages/lib/dist/es/es-ES.js 5.36 kB
packages/lib/dist/es/fi-FI.js 5.35 kB
packages/lib/dist/es/fr-FR.js 5.47 kB
packages/lib/dist/es/hr-HR.js 5.49 kB
packages/lib/dist/es/hu-HU.js 5.78 kB
packages/lib/dist/es/it-IT.js 5.34 kB
packages/lib/dist/es/ja-JP.js 6.18 kB
packages/lib/dist/es/ko-KR.js 5.78 kB
packages/lib/dist/es/nl-NL.js 5.37 kB
packages/lib/dist/es/no-NO.js 5.25 kB
packages/lib/dist/es/pl-PL.js 5.76 kB
packages/lib/dist/es/pt-BR.js 5.32 kB
packages/lib/dist/es/pt-PT.js 5.45 kB
packages/lib/dist/es/ro-RO.js 5.58 kB
packages/lib/dist/es/ru-RU.js 6.76 kB
packages/lib/dist/es/sk-SK.js 5.85 kB
packages/lib/dist/es/sl-SI.js 5.43 kB
packages/lib/dist/es/sv-SE.js 5.23 kB
packages/lib/dist/es/zh-CN.js 5.62 kB
packages/lib/dist/es/zh-TW.js 5.74 kB

compressed-size-action

Base automatically changed from feature/supporting-custom-urls to main August 24, 2023 11:15
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

🦋 Changeset detected

Latest commit: 1af0a4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ribeiroguilherme ribeiroguilherme changed the title [WIP] Bancontact - Using 'bcmc' instead of 'scheme' for paymentMethod.type Bancontact - Using 'bcmc' instead of 'scheme' for paymentMethod.type Aug 24, 2023
@ribeiroguilherme ribeiroguilherme marked this pull request as ready for review August 24, 2023 11:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@ribeiroguilherme ribeiroguilherme merged commit 1b8965f into main Aug 24, 2023
10 checks passed
@ribeiroguilherme ribeiroguilherme deleted the feature/bancontact-using-bcmc-instead-of-scheme branch August 24, 2023 11:31
@github-actions github-actions bot mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants