Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bancontact - Using 'bcmc' instead of 'scheme' for paymentMethod.type #2286

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Bancontact - Using 'bcmc' instead of 'scheme' for paymentMethod.type #2286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b54876
feat: supporting custom urls
ribeiroguilherme Jul 12, 2023
e06c638
fix: reverting safety checks
ribeiroguilherme Jul 14, 2023
475c4b6
feat: using url when resolving
ribeiroguilherme Jul 14, 2023
2e09897
Merge branch 'main' into feature/supporting-custom-urls
ribeiroguilherme Aug 4, 2023
5ca6e7c
feat: changeset + change in the environments + test
ribeiroguilherme Aug 4, 2023
c10c694
feat: updated bcmc paymentmethod type
ribeiroguilherme Aug 4, 2023
9dc24b2
feat: bcmc change
ribeiroguilherme Aug 4, 2023
1af0a4b
Merge branch 'main' into feature/bancontact-using-bcmc-instead-of-scheme
ribeiroguilherme Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-frogs-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@adyen/adyen-web': minor
---

Bancontact now returns paymentMethod.type 'bcmc' instead of 'scheme'
10 changes: 9 additions & 1 deletion packages/lib/src/components/Card/Bancontact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import { CardElement } from './Card';
import { CardElementProps } from './types';
import { CardElementData, CardElementProps } from './types';
import { CVC_POLICY_HIDDEN } from '../internal/SecuredFields/lib/configuration/constants';

class BancontactElement extends CardElement {
public static type = 'bcmc';

constructor(props: CardElementProps) {
super(props);
}
Expand All @@ -12,6 +14,12 @@ class BancontactElement extends CardElement {
brands: ['bcmc', 'maestro', 'visa']
};

formatData(): CardElementData {
const data = super.formatData();
data.paymentMethod.type = this.constructor['type'];
return data;
}

/**
* Now that the Bancontact (BCMC) Card component can accept a number dual branded with Visa (which requires a CVC) it has to be handled differently
* at creation time (no automatic removing of the CVC securedField).
Expand Down
Loading