-
Notifications
You must be signed in to change notification settings - Fork 206
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(vats): move vat-ibc/vat-network from config to network-proposal.js
Previously, certain configurations included vat-ibc and vat-network code as part of bootstrap. These two vats are not properly upgradable, and are not used in our initial launch configuration. To minimize risk, we don't want unused code running on-chain, however we have development and test configurations which *do* need IBC support, so we don't want to delete this code entirely. This commit removes ibc/network from `config.bundles`, and instead creates "proposals" for them (just like we do for Pegasus and the Inter protocol). You can run `agoric run packages/vats/scripts/init-network.js` to create both a set of bundles for installation, and a proposal file to submit in a transaction. Once executed, this will cause the target chain to create vat-network and vat-ibc, and to wire them up just as if they were included at bootstrap time. test-boot-config.js: NON_UPGRADEABLE_VATS now asserts that 'vat-network' and 'vat-ibc' do not appear in the config. The 'pegasus' vat was removed earlier, so I uncommented that line too. closes #7044
- Loading branch information
Showing
15 changed files
with
194 additions
and
198 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
[ | ||
"@agoric/inter-protocol/scripts/init-core.js", | ||
"@agoric/pegasus/scripts/init-core.js" | ||
"@agoric/pegasus/scripts/init-core.js", | ||
"@agoric/vats/scripts/init-network.js" | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { makeHelpers } from '@agoric/deploy-script-support'; | ||
|
||
export const defaultProposalBuilder = async ({ publishRef, install }) => | ||
harden({ | ||
sourceSpec: '../src/proposals/network-proposal.js', | ||
getManifestCall: [ | ||
'getManifestForNetwork', | ||
{ | ||
networkRef: publishRef(install('../src/vat-network.js')), | ||
ibcRef: publishRef(install('../src/vat-ibc.js')), | ||
}, | ||
], | ||
}); | ||
|
||
export default async (homeP, endowments) => { | ||
const { writeCoreProposal } = await makeHelpers(homeP, endowments); | ||
await writeCoreProposal('gov-network', defaultProposalBuilder); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.