vaults bootstrap includes extra bundle: vat-network #7044
Assignees
Labels
Milestone
Comments
dckc
changed the title
dckc
added
bug
This was referenced Mar 14, 2023
|
network vat is mostly about IBC, but see also https://github.com/Agoric/agoric-sdk/blob/master/packages/SwingSet/docs/networking.md need to have some plan to preserve viability of... |
3 tasks
warner
added a commit
that referenced
this issue
May 5, 2023
Previously, certain configurations included vat-ibc and vat-network code as part of bootstrap. These two vats are not properly upgradable, and are not used in our initial launch configuration. To minimize risk, we don't want unused code running on-chain, however we have development and test configurations which *do* need IBC support, so we don't want to delete this code entirely. This commit removes ibc/network from `config.bundles`, and instead creates "proposals" for them (just like we do for Pegasus and the Inter protocol). You can run `agoric run packages/vats/scripts/init-network.js` to create both a set of bundles for installation, and a proposal file to submit in a transaction. Once executed, this will cause the target chain to create vat-network and vat-ibc, and to wire them up just as if they were included at bootstrap time. closes #7044
warner
added a commit
that referenced
this issue
May 5, 2023
Previously, certain configurations included vat-ibc and vat-network code as part of bootstrap. These two vats are not properly upgradable, and are not used in our initial launch configuration. To minimize risk, we don't want unused code running on-chain, however we have development and test configurations which *do* need IBC support, so we don't want to delete this code entirely. This commit removes ibc/network from `config.bundles`, and instead creates "proposals" for them (just like we do for Pegasus and the Inter protocol). You can run `agoric run packages/vats/scripts/init-network.js` to create both a set of bundles for installation, and a proposal file to submit in a transaction. Once executed, this will cause the target chain to create vat-network and vat-ibc, and to wire them up just as if they were included at bootstrap time. closes #7044
warner
added a commit
that referenced
this issue
May 5, 2023
Previously, certain configurations included vat-ibc and vat-network code as part of bootstrap. These two vats are not properly upgradable, and are not used in our initial launch configuration. To minimize risk, we don't want unused code running on-chain, however we have development and test configurations which *do* need IBC support, so we don't want to delete this code entirely. This commit removes ibc/network from `config.bundles`, and instead creates "proposals" for them (just like we do for Pegasus and the Inter protocol). You can run `agoric run packages/vats/scripts/init-network.js` to create both a set of bundles for installation, and a proposal file to submit in a transaction. Once executed, this will cause the target chain to create vat-network and vat-ibc, and to wire them up just as if they were included at bootstrap time. closes #7044
warner
added a commit
that referenced
this issue
May 5, 2023
Previously, certain configurations included vat-ibc and vat-network code as part of bootstrap. These two vats are not properly upgradable, and are not used in our initial launch configuration. To minimize risk, we don't want unused code running on-chain, however we have development and test configurations which *do* need IBC support, so we don't want to delete this code entirely. This commit removes ibc/network from `config.bundles`, and instead creates "proposals" for them (just like we do for Pegasus and the Inter protocol). You can run `agoric run packages/vats/scripts/init-network.js` to create both a set of bundles for installation, and a proposal file to submit in a transaction. Once executed, this will cause the target chain to create vat-network and vat-ibc, and to wire them up just as if they were included at bootstrap time. test-boot-config.js: NON_UPGRADEABLE_VATS now asserts that 'vat-network' and 'vat-ibc' do not appear in the config. The 'pegasus' vat was removed earlier, so I uncommented that line too. test-boot-config.js: TODO: we removed 'setupNetworkProtocols' and 'networkVat' as expected, but it looks like we also removed 'zoe', 'provisioning', and 'bridgeManager'. Why? closes #7044
warner
added a commit
that referenced
this issue
May 5, 2023
Previously, certain configurations included vat-ibc and vat-network code as part of bootstrap. These two vats are not properly upgradable, and are not used in our initial launch configuration. To minimize risk, we don't want unused code running on-chain, however we have development and test configurations which *do* need IBC support, so we don't want to delete this code entirely. This commit removes ibc/network from `config.bundles`, and instead creates "proposals" for them (just like we do for Pegasus and the Inter protocol). You can run `agoric run packages/vats/scripts/init-network.js` to create both a set of bundles for installation, and a proposal file to submit in a transaction. Once executed, this will cause the target chain to create vat-network and vat-ibc, and to wire them up just as if they were included at bootstrap time. test-boot-config.js: NON_UPGRADEABLE_VATS now asserts that 'vat-network' and 'vat-ibc' do not appear in the config. The 'pegasus' vat was removed earlier, so I uncommented that line too. closes #7044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
vat-network is not being used in the vaults release. by removing it from the bootstrap we can avoid having to worry about it being durable or upgradeable. This allows us to defer #5973
Description of the Design
Security Considerations
Scaling Considerations
Test Plan
The text was updated successfully, but these errors were encountered: