Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1 vault not reconstituted and liquidation penalty atom not added to reserve balance #7784

Closed
otoole-brendan opened this issue May 17, 2023 · 1 comment · Fixed by #7788
Closed

1 vault not reconstituted and liquidation penalty atom not added to reserve balance #7784

otoole-brendan opened this issue May 17, 2023 · 1 comment · Fixed by #7788
Assignees
@Chris-Hibbert @otoole-brendan
Labels
bug Something isn't working vaults_triage DO NOT USE
Milestone
Vaults Validation

Comments

@otoole-brendan
Copy link
Contributor

otoole-brendan commented May 17, 2023 •
edited
Loading

Describe the bug

Upon re-testing liquidation reconstitution scenario (flow #2) following PR fixes (#7752) from last night, I discovered:

  • only 1 vault reconstituted (the highest CR vault) (expecting 2 vaults to do so)
  • reconstituted vault value after auction were 14.79 ATOM and 100.5 IST -> was expecting 14.899 but debt is as expected.
  • liquidation penalty ATOM was not added to reserve balance
  • shortfall balance looked correct (5.525)

To Reproduce

Steps to reproduce the behavior:

  1. Using 12.34 oracle price, set up liquidation testing scenario flow Fix mint amounts in deploy.js #2 per https://docs.google.com/document/d/1bXnQ_o3wwfnu-uhX2KSb6ZXB0dU6CsAsGBWm1DXgmE0/edit?usp=sharing
  2. Change to 9.99 to trigger liquidation
  3. Observe auction start and complete.
  4. Check reserve metrics to check post-auction values
  5. Check Vaults UI to check reconstituted vaults

Expected behavior

  • Vault 1 and vault 2 should have been reconstituted
  • liquidation atom penalty should have been added to reserve balance

Platform Environment

  • what OS are you using? what version of Node.js?
  • is there anything special/unusual about your platform?
  • what version of the Agoric-SDK are you using? (run git describe --tags --always)

Additional context

Add any other context about the problem here.

Screenshots

image.pngIf applicable, add screenshots to help explain your problem, especially for UI interactions.

image.png
@otoole-brendan otoole-brendan added bug Something isn't working v1_triaged DO NOT USE labels May 17, 2023
@otoole-brendan otoole-brendan added this to the Vaults Validation milestone May 17, 2023
@ivanlei ivanlei added vaults_triage DO NOT USE and removed v1_triaged DO NOT USE labels May 17, 2023
@dckc dckc assigned otoole-brendan and unassigned Chris-Hibbert May 18, 2023
@dckc
Copy link
Member

dckc commented May 18, 2023

@Chris-Hibbert investigated this and concluded it's as-designed.
@otoole-brendan plans to double-check.

Chris-Hibbert added a commit that referenced this issue May 18, 2023
@Chris-Hibbert
fix(vaults): reconstitue vaults correctly
d808a5d 
fixes: #7784

I over-corrected with my last fix, generalizing a fix that applied to
flow #1 to apply also to flow 2b, which it did not. The output here
now matches the scenarios the PMs have been testing.
@Chris-Hibbert Chris-Hibbert mentioned this issue May 18, 2023
Merged
This was referenced May 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

@otoole-brendan otoole-brendan

Labels
bug Something isn't working vaults_triage DO NOT USE
Projects
None yet
Milestone
Vaults Validation
Development

Successfully merging a pull request may close this issue.

fix(vaults): reconstitute vaults correctly Agoric/agoric-sdk
4 participants
@dckc @ivanlei @Chris-Hibbert @otoole-brendan