fix(vaults): when reconstituting vaults, report correct shortfall #7752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
May 16, 2023
There was a problem hiding this comment.
Fix LGTM. There's a lint error I made a commit for. Also I was thinking about how to have prevented this and noticed that recordShortfallAndProceeds is supposed to be called whenever it's done liquidating, so I moved the work into markDoneLiquidating.
I pushed for expediency. It has a fixup commit so still requires a rebase to merge.
| facets.helper.sendToReserve(collatRemaining, liqSeat); | ||
| facets.helper.markDoneLiquidating(totalDebt, totalCollateral); | ||
| facets.helper.recordShortfallAndProceeds({ | ||
| overage: accounting.overage, |
There was a problem hiding this comment.
without knowing the types, reviewing in web UI it looks like this could be missing some properties.
Suggested change
| overage: accounting.overage, | |
| ...accounting, |
fixes: #7474 We weren't reducing the reported shortfall by the amount of debt being restored to some vaults.
turadg
force-pushed
the
7474-doubleReserve
branch
from
adde108
to
aa76acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7474
Description
We weren't reducing the reported shortfall by the amount of debt being restored to some vaults.
Security Considerations
None.
Scaling Considerations
Not an issue.
Documentation Considerations
N/A
Testing Considerations
Corrected a test.