switch from tape/tap to AVA for tests #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
1568-test-with-ava
branch
8 times, most recently
from
ba42673
to
ed59b89
Compare
dtribble
approved these changes
Aug 20, 2020
| /There is no entry for "c"./, | ||
| ); | ||
| t.end(); | ||
| t.throws(() => importer.lookupImport('emptyPixel'), { |
There was a problem hiding this comment.
I'd put the reporter on it's own line, but maybe this is a prettier thing?
There was a problem hiding this comment.
yeah, I typed it on its own line, then prettier rewrote it into that ugly thing
although there are no tests written, so 'yarn test' is still disabled
warner
force-pushed
the
1568-test-with-ava
branch
from
ed59b89
to
91887c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the process and converts a handful of packages.
refs #1568