-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate testing to AVA #1568
Comments
@michaelfig points out that we have non-test files with names like I'll look to see if we also have Either way, we need to update our coding-standards document to recommend the naming scheme. |
From what I can tell in the config docs, AVA processes configuration data from exactly one of three places:
The We want to enable both a top-level do-all-packages-in-parallel We could factor out the per-package configs into a separate shared file (perhaps When we finally move to ESM (#527), there will be a conflict between heterogenous packages (some ESM, some CJS+ |
I'm going to proceed one package at a time, leaving the top-level |
I've checked a simple package (with no dependencies) with |
AVA rejects |
chore: update 'spawner' package to use AVA refs #1568
chore: update 'dapp-svelte-wallet' package to use AVA refs #1568
fix: actually test cosmic-swingset files in parallel refs #1568
chore: update 'sharing-service' package to use AVA refs #1568
update swingset-runner/swingstore to AVA refs #1568
All packages have been converted. The remaining step is make the top-level This might improve reporting: AVA would be in control of all tests. Success/failure/progress would be reported one test file at a time. AVA would not even be aware of what package contains each test file. And it could improve performance slightly, by increasing the opportunity for parallelism. The complication is that we can't use the same AVA config for all our tests, specifically the However the 10 that actually exercise metering couldn't be included under that command. We'd have to have two separate We'd need to remove all the manual |
We no longer use |
closing this in favor of the smaller #4493 |
Our current best-looking result from the #1335 survey is to use AVA instead of tap/tape.
This ticket is about performing that migration.
Questions for me to answer first:
-r esm
)-r esm
for all packages that are not yet set totype: module
console.log
to debug test problemsI'm hoping to find a way to convert one modules at a time, for smaller PRs, but I won't let that stop me.
I'll be drawing from @dtribble 's #1447 PR.
The text was updated successfully, but these errors were encountered: