chore: update 'SwingSet' package to use AVA for testing #1579
Conversation
warner
force-pushed
the
1568-test-with-ava
branch
from
193dbc8
to
c976ebb
Compare
| isSide(objP, side) { | ||
| return E(objP) | ||
| .side() | ||
| .then(s => t.is(s, side, `obj.side() is ${side}`)); |
There was a problem hiding this comment.
Given the await style, these actual assertions should be moved out to the outside. This is a case where this test woudl require a `plan`` because who knows whether the assertions will simply never get invoke and so not have a chance to fail. Bit if they are moved to the top instead, then it would just flow.
| )); | ||
| const rightRef = leftBootstrap(); | ||
|
|
||
| await E(rightRef).isSide(rightRef, 'right'); |
There was a problem hiding this comment.
Perhaps
| await E(rightRef).isSide(rightRef, 'right'); | |
| cons rside = await s.side(); | |
| t.is(rside, 'right'); |
| test('try disconnecting captp', async t => { | ||
| const objs = []; | ||
| const rejected = []; | ||
| const { getBootstrap, abort } = makeCapTP( |
There was a problem hiding this comment.
all the makeCapTP invocations would be clearer if the fancy arguments were refactored into named consts.
| import { E, makeCapTP } from '../lib/captp'; | ||
|
|
||
| test('try disconnecting captp', async t => { | ||
| const objs = []; |
There was a problem hiding this comment.
I have no idea what this test is trying to do, but it really needs a plan(X) to make sure that assertions are gettign executed.
| () => ns4.f7WriteGlobal(5), | ||
| 'Cannot assign to read only property', | ||
| { message: /Cannot assign to read only property/ }, |
There was a problem hiding this comment.
Why switch from exact mach to RE within the error string?
There was a problem hiding this comment.
the test failed when I did that, apparently the full error string is longer than that, and tap/tape's assertion was actually doing a substring match
warner
force-pushed
the
1568-test-with-ava
branch
from
15c233e
to
7e184dd
Compare
|
thanks, I'll schedule those fixes for a subsequent PR |
refs #1568