Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base for Treasury Governance branch #3389

Closed
wants to merge 7 commits into from
Closed

Conversation

Chris-Hibbert
Copy link
Contributor

Treasury Governance Branch

This is the base of a branch for governance work that shouldn't be merged until it's complete because it enables management control of fundamental contracts like Treasury.

The overall issue for managing development of governance is #3185.

To the extent possible, we'll continue to add general purpose governance code to the main branch, and rebase this as necessary to keep up.

update testing imports for issue 768
add minimal types
better fix for test dependencies
change jsconfig.json includes, update packages, change swingset test (#3300)
update committeeRegistrar for relocation of voterFacet
integrate with changes to ballot PR (3233)
make ballotCounter instance accessible from ballot
add more to terms of ballotCounter (closureRule)
add more to public facet of Registrar
one registrar per contract/vat: details in terms
use zcf.getInstance() to supply instances

In tests
  voters look up their own positions
  voters cast ballots on notification
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Large Core Economy OBSOLETE in favor of INTER-protocol Governance Governance labels Jun 21, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Phase 4: Governance milestone Jun 21, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Jun 21, 2021
@Chris-Hibbert Chris-Hibbert marked this pull request as draft June 22, 2021 00:02
I want the Treasury changes to be on top of the registrar (#3299)
which is still in review. Git/GitHub doesn't allow an empty PR to be
rebased onto anther PR, so this adds a commit..
@Chris-Hibbert Chris-Hibbert changed the base branch from master to registrar-3188 June 22, 2021 00:22
@Chris-Hibbert Chris-Hibbert force-pushed the registrar-3188 branch 2 times, most recently from 8b92571 to 44e223f Compare June 23, 2021 17:06
Base automatically changed from registrar-3188 to master June 23, 2021 17:35
@rowgraus rowgraus modified the milestones: Beta Phase 4: Governance, Testnet: Metering Phase Jul 28, 2021
@rowgraus rowgraus removed this from the Testnet: Metering Phase milestone Aug 12, 2021
@Chris-Hibbert
Copy link
Contributor Author

No longer necessary, since #3473 and #3622 have been merged

@Chris-Hibbert Chris-Hibbert deleted the TreasuryGovernance branch January 7, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Governance Governance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants