Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradable network vat #5973

Closed
wants to merge 2 commits into from
Closed

Upgradable network vat #5973

wants to merge 2 commits into from

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Aug 16, 2022

This is a first cut at making the network vat upgradable.

It also includes a refactoring that moves the network vat code from being in a mix of the SwingSet package and the vats package to being 100% in the vats package.

Currently it passes all the tests I could find that in any way implicate the network vat (in the vats, solo, cosmic-swingset, and pegasus packages). However, while it now keeps all of its state that I could identify in durable storage, there is as yet no test as to whether it actually achieves upgradability. As such, this PR should be viewed as a step on the road to achieving upgradability without yet making any assertions as to whether that destination has in fact been reached. Consequently I would leave the motivating issue (#5696) open for the time being.

I have made an unsuccessful first cut at attempting to test upgradability, but various complications with the current network vat tests (most notably that these tests don't actually run in a swingset) have meant that while the proposed testing strategy that @michaelfig pointed me at seems to be sound (basically, a network vat restart in the middle of the test network - ibc test), the existing tests themselves do not lend themselves to being adapted in this way. This is work for the future but I believe we have concluded that it is not on the current critical path.

@FUDCo FUDCo added enhancement New feature or request hygiene Tidying up around the house labels Aug 16, 2022
@FUDCo FUDCo self-assigned this Aug 16, 2022
@michaelfig
Copy link
Member

Sorry, it looks like I didn't approve in time to avoid bitrot. Chip, would you be able to pick this up again if you could update it to current master? I'll gladly review this time.

@warner warner mentioned this pull request Jan 25, 2023
@warner
Copy link
Member

warner commented Jan 26, 2023

Incidentally, it sounds like we don't have plans to include dynamic IBC in the Vaults release, therefore we won't be including a vat-network in the bulldozer upgrade. The bundle might be included anyway, by virtue of being in decentral-core-config.json, except that we probably won't use that config file (we'd use something like decentral-main-psm instead). cc @dckc

@turadg
Copy link
Member

turadg commented Feb 13, 2024

Subsumed by #8721

@turadg turadg closed this Feb 13, 2024
@warner warner deleted the 5696-upgradable-network-vat branch September 1, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hygiene Tidying up around the house
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants