feat(vats): facilitate launching additional PSMs #6142

dckc · 2022-09-06T01:58:33Z

goal:
closes: #6021

Description

This exposes the startPSM and makeAnchorAsset functions to the core-eval scope; as a result, a proposal to start a PSM for DAI is just a few lines.

TODO:

handle naming issues around multiple PSMs

Security Considerations

TODO:

refine permit of example proposal
set default fee limit to 0 IST

Documentation Considerations

@rowgraus should we put something about this process in some Inter Protocol docs? Or just wait until it's time to discuss an actual proposal with the community?

Testing Considerations

I did local-chain end-to-end integration testing, as noted below

dckc · 2022-09-06T03:53:21Z

How to introduce additional PSMs to the psmCharter?

@dtribble @Chris-Hibbert bootstrap wires up "the" PSM to psmCharter for governing minting limits and such. When we start another PSM, I just realized we need to introduce it to the psmCharter somehow too.

This helps with #6142, but might be merged into that or #6139.

dtribble

I have some questions in the comments.

packages/inter-protocol/test/psm/gov-add-psm-permit.json

packages/inter-protocol/test/psm/gov-add-psm.js

dtribble · 2022-09-07T05:28:34Z

packages/inter-protocol/test/psm/gov-add-psm-permit.json

+      "economicCommittee": true
+    },
+    "produce": {
+      "$ISSUE": "These names assume there can be only one psm",


Are these intended to remain?

no. hence #6142 (comment) and #6146 and such.

* refactor: make PSM bootstrap support multiple brands This helps with #6142, but might be merged into that or #6139. * chore(inter-protocol): register PSM under anchor keyword * chore: clean-ups and comments suggested in review. * build(ERTP): increase test timeout to mitigate CI failure Co-authored-by: Dan Connolly <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Chris-Hibbert · 2022-09-07T16:34:32Z

I think #6146 addressed

handle naming issues around multiple PSMs
Can we check that off in the top-comment, or is there more to be done for naming?

dckc · 2022-09-07T16:39:14Z

connection to the psmCharter is working, finally:

2022-09-07T16:33:46.716Z block-manager: block 28 begin
2022-09-07T16:33:46.721Z SwingSet: vat: v1: issuer DAI: new Promise
2022-09-07T16:33:46.722Z SwingSet: vat: v1: brand DAI: new Promise
2022-09-07T16:33:46.727Z SwingSet: vat: v1: starting PSM: { keyword: 'DAI', decimalPlaces: 18, denom: 'ibc/toydai', proposedName: 'Maker DAI' }
XS snapshot written to /home/connolly/projects/agoric-sdk/packages/cosmic-swingset/t1/n0/data/ag-cosmos-chain-state/xs-snapshots/47d5177d084b205d875cf75dec79225aa57cf2e61d2584
0f4baa9f1aa4af9da5.gz : 1635995 bytes compressed, 7494503 raw
2022-09-07T16:33:47.902Z block-manager: block 28 commit
2022-09-07T16:33:51.736Z block-manager: block 29 begin
2022-09-07T16:33:51.897Z block-manager: block 29 commit
2022-09-07T16:33:56.749Z block-manager: block 30 begin
XS snapshot written to /home/connolly/projects/agoric-sdk/packages/cosmic-swingset/t1/n0/data/ag-cosmos-chain-state/xs-snapshots/0a106938f822316b12246b919fa522475b154b526938f5
1914863e2f0475b33f.gz : 1555397 bytes compressed, 7046479 raw
2022-09-07T16:33:58.057Z block-manager: block 30 commit
2022-09-07T16:34:01.759Z block-manager: block 31 begin
2022-09-07T16:34:02.874Z SwingSet: vat: v20: PSM Starting Object [Alleged: DAI brand] {} { denominator: { brand: Object [Alleged: IST brand] {}, value: 100n }, numerator: { br
and: Object [Alleged: DAI brand] {}, value: 100n } }
XS snapshot written to /home/connolly/projects/agoric-sdk/packages/cosmic-swingset/t1/n0/data/ag-cosmos-chain-state/xs-snapshots/75d15629896ebebc681d8bf282946327b7749da2578774
1ea2e72abdd9d22f10.gz : 1690238 bytes compressed, 7657983 raw
2022-09-07T16:34:03.158Z block-manager: block 31 commit
2022-09-07T16:34:06.772Z block-manager: block 32 begin
2022-09-07T16:34:06.868Z block-manager: block 32 commit
2022-09-07T16:34:11.783Z block-manager: block 33 begin
2022-09-07T16:34:11.922Z block-manager: block 33 commit
2022-09-07T16:34:16.798Z block-manager: block 34 begin
2022-09-07T16:34:16.970Z block-manager: block 34 commit
2022-09-07T16:34:21.815Z block-manager: block 35 begin
2022-09-07T16:34:21.927Z SwingSet: vat: v11: psmCharter: adding instance { minted: Object [Alleged: IST brand] {}, anchor: Object [Alleged: DAI brand] {} }
2022-09-07T16:34:21.937Z SwingSet: vat: v1: started PSM: { options: { anchorOptions: { keyword: 'DAI', decimalPlaces: 18, denom: 'ibc/toydai', proposedName: 'Maker DAI' } }, W
antStableFeeBP: 1n, GiveStableFeeBP: 3n, MINT_LIMIT: 0n }
2022-09-07T16:34:21.964Z block-manager: block 35 commit

dckc · 2022-09-07T16:49:45Z

@Chris-Hibbert and co, PTAL.

I think #6146 addressed "handle naming issues around multiple PSMs"
Can we check that off in the top-comment, or is there more to be done for naming?

There was some wiring up the psmCharter, but it's done now and checked off.

dckc · 2022-09-07T16:52:59Z

re docs: I can imagine the chainStorage and agoricNames stuff should be documented.

for now:

$ agoric follow :published.agoricNames.instance
[
  [
    "economicCommittee",
    slot(0,"Alleged: InstanceHandle"),
  ],
  [
    "psm-IST-AUSD",
    slot(1,"Alleged: InstanceHandle"),
  ],
  [
    "psm-IST-DAI",
    slot(2,"Alleged: InstanceHandle"),
  ],
]

$ agd query vstorage children published.psm.IST
children:
- AUSD
- DAI

dckc · 2022-09-07T17:19:02Z

packages/inter-protocol/src/psm/psmCharter.js

@@ -46,7 +49,9 @@ export const start = async (zcf, privateArgs) => {
    );
  };

-  const makeOfferFilterInvitation = () => {
+  /** @param {Instance} instance */


@turadg I'm interested to get some training on using Instance types parameterized by the contract start function and such.

check out https://github.com/Agoric/agoric-sdk/compare/type-instance

dckc · 2022-09-07T17:40:57Z

oops! I force-pushed after requesting review. I hope I didn't make too much of a mess.

Chris-Hibbert

LGTM

Chris-Hibbert · 2022-09-07T18:59:06Z

packages/vats/src/core/boot-psm.js

+import * as startPSMmod from '@agoric/inter-protocol/src/proposals/startPSM.js';
+import * as ERTPmod from '@agoric/ertp';


Capitalization nit: shouldn't these be startPSMMod and ERTPMod?

could be. if this version doesn't pass CI, I'll tweak it.

- provide startPSM module to core-eval - support proposedName, decimalPlaces in anchorOptions - check shape of anchorOptions

... in order to avoid importing sim-behaviors.js into boot-psm.js

rather than starting psmCharter with "the" PSM

... which moved to startPSM.js in inter-protocol

dckc requested review from michaelfig and dtribble September 6, 2022 01:58

dckc force-pushed the 6021-more-psm-assets branch from 00b568b to cc6b031 Compare September 6, 2022 04:02

dckc marked this pull request as ready for review September 6, 2022 04:03

dckc requested a review from turadg as a code owner September 6, 2022 04:03

dckc mentioned this pull request Sep 6, 2022

Write a charter for multi-asset PSM param governance #6089

Closed

Chris-Hibbert added a commit that referenced this pull request Sep 6, 2022

refactor: make PSM bootstrap support multiple brands

282d169

This helps with #6142, but might be merged into that or #6139.

Chris-Hibbert mentioned this pull request Sep 6, 2022

feat: make PSM bootstrap support multiple brands #6146

Merged

Chris-Hibbert added a commit that referenced this pull request Sep 7, 2022

refactor: make PSM bootstrap support multiple brands

dd4887d

This helps with #6142, but might be merged into that or #6139.

dckc force-pushed the 6021-more-psm-assets branch from cc6b031 to ced7bff Compare September 7, 2022 03:15

dtribble reviewed Sep 7, 2022

View reviewed changes

dckc marked this pull request as draft September 7, 2022 05:43

dckc force-pushed the 6021-more-psm-assets branch from ced7bff to 0492f10 Compare September 7, 2022 14:05

dckc force-pushed the 6021-more-psm-assets branch from 876d46a to 7d903d1 Compare September 7, 2022 15:56

dckc force-pushed the 6021-more-psm-assets branch from 7d903d1 to da1785d Compare September 7, 2022 16:36

dckc marked this pull request as ready for review September 7, 2022 16:48

dckc force-pushed the 6021-more-psm-assets branch from da1785d to ab6beb8 Compare September 7, 2022 16:55

dckc commented Sep 7, 2022

View reviewed changes

dckc force-pushed the 6021-more-psm-assets branch from ab6beb8 to 18f5de1 Compare September 7, 2022 17:40

Chris-Hibbert approved these changes Sep 7, 2022

View reviewed changes

dckc added 3 commits September 7, 2022 17:53

test(inter-protocol): example proposal to add a PSM for DAI

cd07d57

feat(vats): facilitate launching additional PSMs

6bf3164

- provide startPSM module to core-eval - support proposedName, decimalPlaces in anchorOptions - check shape of anchorOptions

refactor(inter-protocol): factor out startEconCommittee.js

2f35f0e

... in order to avoid importing sim-behaviors.js into boot-psm.js

dckc added 7 commits September 7, 2022 17:53

fix(vats): avoid importing sim-behaviors into boot-psm.js

356d522

fix(inter-protocol): introduce each PSM to the psmCharter

48be0f8

rather than starting psmCharter with "the" PSM

chore(vats): prune PSM_GOV_INSTALL_MANIFEST

2c2ca0e

... which moved to startPSM.js in inter-protocol

feat(vats): include startPSMCharter in PSM bootstrap

7bb593c

fixup! refactor(inter-protocol): factor out startEconCommittee.js

bc09966

fixup! fix(inter-protocol): introduce each PSM to the psmCharter

d898d4e

fixup! feat(vats): include startPSMCharter in PSM bootstrap

d66e91c

dckc force-pushed the 6021-more-psm-assets branch from 1f27602 to d66e91c Compare September 7, 2022 23:01

test(smart-wallet): update psm instance key

710151f

dckc added the automerge:no-update (expert!) Automatically merge without updates label Sep 8, 2022

Merge branch 'master' into 6021-more-psm-assets

fc5213d

mergify bot merged commit bd7ae9c into master Sep 8, 2022

mergify bot deleted the 6021-more-psm-assets branch September 8, 2022 01:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vats): facilitate launching additional PSMs #6142

feat(vats): facilitate launching additional PSMs #6142

dckc commented Sep 6, 2022 •

edited

Loading

dckc commented Sep 6, 2022

dtribble left a comment

dtribble Sep 7, 2022

dckc Sep 7, 2022 •

edited

Loading

Chris-Hibbert commented Sep 7, 2022

dckc commented Sep 7, 2022 •

edited

Loading

dckc commented Sep 7, 2022

dckc commented Sep 7, 2022 •

edited

Loading

dckc Sep 7, 2022

turadg Sep 8, 2022

dckc commented Sep 7, 2022

Chris-Hibbert left a comment

Chris-Hibbert Sep 7, 2022

dckc Sep 7, 2022

		import * as startPSMmod from '@agoric/inter-protocol/src/proposals/startPSM.js';
		import * as ERTPmod from '@agoric/ertp';

feat(vats): facilitate launching additional PSMs #6142

feat(vats): facilitate launching additional PSMs #6142

Conversation

dckc commented Sep 6, 2022 • edited Loading

Description

Security Considerations

Documentation Considerations

Testing Considerations

dckc commented Sep 6, 2022

How to introduce additional PSMs to the psmCharter?

dtribble left a comment

Choose a reason for hiding this comment

dtribble Sep 7, 2022

Choose a reason for hiding this comment

dckc Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

Chris-Hibbert commented Sep 7, 2022

dckc commented Sep 7, 2022 • edited Loading

dckc commented Sep 7, 2022

dckc commented Sep 7, 2022 • edited Loading

dckc Sep 7, 2022

Choose a reason for hiding this comment

turadg Sep 8, 2022

Choose a reason for hiding this comment

dckc commented Sep 7, 2022

Chris-Hibbert left a comment

Choose a reason for hiding this comment

Chris-Hibbert Sep 7, 2022

Choose a reason for hiding this comment

dckc Sep 7, 2022

Choose a reason for hiding this comment

dckc commented Sep 6, 2022 •

edited

Loading

dckc Sep 7, 2022 •

edited

Loading

dckc commented Sep 7, 2022 •

edited

Loading

dckc commented Sep 7, 2022 •

edited

Loading