feat: make PSM bootstrap support multiple brands #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
force-pushed
the
6142-psmFacets
branch
from
282d169
to
dd4887d
Compare
dckc
approved these changes
Sep 7, 2022
Comment on lines
144
to
150
| const newPsmFacets = { | ||
| psm: E(governorFacets.creatorFacet).getInstance(), | ||
| psmGovernor: governorFacets.instance, | ||
| psmCreatorFacet: E(governorFacets.creatorFacet).getCreatorFacet(), | ||
| psmAdminFacet: E(governorFacets.creatorFacet).getAdminFacet(), | ||
| psmGovernorCreatorFacet: governorFacets.creatorFacet, | ||
| }; |
There was a problem hiding this comment.
I wonder if we're going to regret storing these promises.
There was a problem hiding this comment.
You're probably right.
| /** @typedef {import('./econ-behaviors.js').EconomyBootstrapSpace} EconomyBootstrapSpace */ | ||
|
|
||
| /** @param {BootstrapSpace & EconomyBootstrapSpace & { devices: { vatAdmin: any }, vatPowers: { D: DProxy }, }} powers */ | ||
| // /** @param {BootstrapSpace & { devices: { vatAdmin: any }, vatPowers: { D: DProxy }, }} powers */ |
There was a problem hiding this comment.
Did you mean to keep this commented-out line?
| installation: { | ||
| produce: { contractGovernor, committee, binaryVoteCounter, psm }, | ||
| }, | ||
| }) => { | ||
| psmFacets.resolve(makeScalarMapStore()); |
There was a problem hiding this comment.
Perhaps leave a comment for our future selves about what this is doing here?
dckc
changed the title
This was referenced Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6142
refs: #6139
Description
Make PSM bootstrap support multiple brands
This helps with #6142, but might be merged into that or #6139.
Security Considerations
The PSM facets are available throughout PSM. That seems acceptable.
Documentation Considerations
None
Testing Considerations
Existing tests continue to pass. Since some are using PSM bootstrap, we can tell that it successfully stored one PSM and retrieved it. I presume two wouldn't be harder, but haven't written tests.